Update supported javascript mimetypes

Update supported javascript mimetypes

This patch adds support for the following javascript
mimetypes:
text/javascript1.0
text/javascript1.4
text/javascript1.5
text/x-javascript
text/x-ecmascript
application/x-ecmascript

Which we are required to support per the spec at
https://html.spec.whatwg.org/#javascript-mime-type

BUG=582662
Committed: https://crrev.com/a84842163b3da3edded789ec8a751df41e0f42b9
Cr-Commit-Position: refs/heads/master@{#404681}

[Charlie Harrison, 2016-07-08 22:42:59]

csharrison@chromium.org changed reviewers:
+ asanka@chromium.org, yoav@yoav.ws

[Charlie Harrison, 2016-07-08 22:43:00]

asanka, can you look at the changes to mime_util? The comment I deleted was so
out of date but let me know if you want to me to add anything else.

yoav, can you look at the rest?

[asanka, 2016-07-08 22:52:09]

https://codereview.chromium.org/2135753002/diff/20001/components/mime_util/mi...
File components/mime_util/mime_util.cc (right):

https://codereview.chromium.org/2135753002/diff/20001/components/mime_util/mi...
components/mime_util/mime_util.cc:39: //  Firefox 47 accepts all of the values
in
At this point we should be keeping this list in sync with the spec instead of
specific versions of other browsers. Let's add a reference to the spec and drop
the comment about FF 47. Note that the spec explicitly calls out "User agents
must recognize all JavaScript MIME types", which is sufficient justification.

https://codereview.chromium.org/2135753002/diff/20001/components/mime_util/mi...
components/mime_util/mime_util.cc:41: const char* const
kSupportedJavascriptTypes[] = {"text/javascript",
Sort to match spec.

[Yoav Weiss, 2016-07-11 09:43:21]

Overall looks good, but I'm slightly worried about adding things to `language`.
It seems obsolete and something we would potentially remove if we could. Is
there content out there that relies on these new language values? Do other
browsers support them?

https://codereview.chromium.org/2135753002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/ScriptLoader.cpp (right):

https://codereview.chromium.org/2135753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/ScriptLoader.cpp:150:
languages.add("x-javascript");
Is that defined in a spec somewhere? Looking at
https://html.spec.whatwg.org/#obsolete-but-conforming-features:attr-script-la...
this seems underspecified.

[Charlie Harrison, 2016-07-11 14:43:32]

https://codereview.chromium.org/2135753002/diff/20001/components/mime_util/mi...
File components/mime_util/mime_util.cc (right):

https://codereview.chromium.org/2135753002/diff/20001/components/mime_util/mi...
components/mime_util/mime_util.cc:39: //  Firefox 47 accepts all of the values
in
On 2016/07/08 22:52:09, asanka wrote:
> At this point we should be keeping this list in sync with the spec instead of
> specific versions of other browsers. Let's add a reference to the spec and
drop
> the comment about FF 47. Note that the spec explicitly calls out "User agents
> must recognize all JavaScript MIME types", which is sufficient justification.

Is the link to the whatwg spec not sufficient here? I've updated the comment.

https://codereview.chromium.org/2135753002/diff/20001/components/mime_util/mi...
components/mime_util/mime_util.cc:41: const char* const
kSupportedJavascriptTypes[] = {"text/javascript",
On 2016/07/08 22:52:09, asanka wrote:
> Sort to match spec.

Done.

https://codereview.chromium.org/2135753002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/ScriptLoader.cpp (right):

https://codereview.chromium.org/2135753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/ScriptLoader.cpp:150:
languages.add("x-javascript");
On 2016/07/11 09:43:20, Yoav Weiss wrote:
> Is that defined in a spec somewhere? Looking at
>
https://html.spec.whatwg.org/#obsolete-but-conforming-features:attr-script-la...
> this seems underspecified.

You're right. These changes are not in scope for this CL. Removing.

[asanka, 2016-07-11 14:52:39]

LGTM. Thanks!

https://codereview.chromium.org/2135753002/diff/20001/components/mime_util/mi...
File components/mime_util/mime_util.cc (right):

https://codereview.chromium.org/2135753002/diff/20001/components/mime_util/mi...
components/mime_util/mime_util.cc:39: //  Firefox 47 accepts all of the values
in
On 2016/07/11 at 14:43:32, csharrison wrote:
> On 2016/07/08 22:52:09, asanka wrote:
> > At this point we should be keeping this list in sync with the spec instead
of
> > specific versions of other browsers. Let's add a reference to the spec and
drop
> > the comment about FF 47. Note that the spec explicitly calls out "User
agents
> > must recognize all JavaScript MIME types", which is sufficient
justification.
> 
> Is the link to the whatwg spec not sufficient here? I've updated the comment.

Yup. That's sufficient.

To clarify, I was referring to the "FireFox 47 accepts all of the values in ..
so we should too" part. Both browsers are trying to be compliant with the spec
rather than trying to be compliant with each other. Same goes for CL
description.

[Charlie Harrison, 2016-07-11 14:54:38]

Description was changed from

==========
Update supported javascript mimetypes

This patch adds support for the following javascript mimetypes:
text/javascript1.0
text/javascript1.4
text/javascript1.5
text/x-javascript
text/x-ecmascript
application/x-ecmascript

Which are all supported by Firefox 47

BUG=582662
==========

to

==========
Update supported javascript mimetypes

This patch adds support for the following javascript 
mimetypes:
text/javascript1.0
text/javascript1.4
text/javascript1.5
text/x-javascript
text/x-ecmascript
application/x-ecmascript

Which we are required to support per the spec at
https://html.spec.whatwg.org/#javascript-mime-type

BUG=582662
==========

[Yoav Weiss, 2016-07-11 14:59:14]

On 2016/07/11 14:52:39, asanka wrote:
> LGTM. Thanks!
> 
>
https://codereview.chromium.org/2135753002/diff/20001/components/mime_util/mi...
> File components/mime_util/mime_util.cc (right):
> 
>
https://codereview.chromium.org/2135753002/diff/20001/components/mime_util/mi...
> components/mime_util/mime_util.cc:39: //  Firefox 47 accepts all of the values
> in
> On 2016/07/11 at 14:43:32, csharrison wrote:
> > On 2016/07/08 22:52:09, asanka wrote:
> > > At this point we should be keeping this list in sync with the spec instead
> of
> > > specific versions of other browsers. Let's add a reference to the spec and
> drop
> > > the comment about FF 47. Note that the spec explicitly calls out "User
> agents
> > > must recognize all JavaScript MIME types", which is sufficient
> justification.
> > 
> > Is the link to the whatwg spec not sufficient here? I've updated the
comment.
> 
> Yup. That's sufficient.
> 
> To clarify, I was referring to the "FireFox 47 accepts all of the values in ..
> so we should too" part. Both browsers are trying to be compliant with the spec
> rather than trying to be compliant with each other. Same goes for CL
> description.

core/ (tests) LGTM! :)

[Charlie Harrison, 2016-07-11 15:00:13]

Thanks, I've updated the CL description. Landing.

[Charlie Harrison, 2016-07-11 15:00:35]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2016-07-11 15:00:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 17:06:05]

Description was changed from

==========
Update supported javascript mimetypes

This patch adds support for the following javascript 
mimetypes:
text/javascript1.0
text/javascript1.4
text/javascript1.5
text/x-javascript
text/x-ecmascript
application/x-ecmascript

Which we are required to support per the spec at
https://html.spec.whatwg.org/#javascript-mime-type

BUG=582662
==========

to

==========
Update supported javascript mimetypes

This patch adds support for the following javascript 
mimetypes:
text/javascript1.0
text/javascript1.4
text/javascript1.5
text/x-javascript
text/x-ecmascript
application/x-ecmascript

Which we are required to support per the spec at
https://html.spec.whatwg.org/#javascript-mime-type

BUG=582662
==========

[commit-bot: I haz the power, 2016-07-11 17:06:06]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-11 17:06:14]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-11 17:09:56]

Description was changed from

==========
Update supported javascript mimetypes

This patch adds support for the following javascript 
mimetypes:
text/javascript1.0
text/javascript1.4
text/javascript1.5
text/x-javascript
text/x-ecmascript
application/x-ecmascript

Which we are required to support per the spec at
https://html.spec.whatwg.org/#javascript-mime-type

BUG=582662
==========

to

==========
Update supported javascript mimetypes

This patch adds support for the following javascript
mimetypes:
text/javascript1.0
text/javascript1.4
text/javascript1.5
text/x-javascript
text/x-ecmascript
application/x-ecmascript

Which we are required to support per the spec at
https://html.spec.whatwg.org/#javascript-mime-type

BUG=582662

Committed: https://crrev.com/a84842163b3da3edded789ec8a751df41e0f42b9
Cr-Commit-Position: refs/heads/master@{#404681}
==========

[commit-bot: I haz the power, 2016-07-11 17:09:57]

Patchset 5 (id:??) landed as
https://crrev.com/a84842163b3da3edded789ec8a751df41e0f42b9
Cr-Commit-Position: refs/heads/master@{#404681}