Update supported javascript mimetypes

components/mime_util/mime_util.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/mime_util/mime_util.h"
 
 #include <stddef.h>
 
 #include "base/containers/hash_tables.h"
 #include "base/lazy_instance.h"
@@ skipping 18 matching lines @@
                                             "image/jpg",
                                             "image/webp",
                                             "image/png",
                                             "image/gif",
                                             "image/bmp",
                                             "image/vnd.microsoft.icon",  // ico
                                             "image/x-icon",              // ico
                                             "image/x-xbitmap",           // xbm
                                             "image/x-png"};
 
-//  Mozilla 1.8 and WinIE 7 both accept text/javascript and text/ecmascript.
-//  Mozilla 1.8 accepts application/javascript, application/ecmascript, and
-// application/x-javascript, but WinIE 7 doesn't.
-//  WinIE 7 accepts text/javascript1.1 - text/javascript1.3, text/jscript, and
-// text/livescript, but Mozilla 1.8 doesn't.
-//  Mozilla 1.8 allows leading and trailing whitespace, but WinIE 7 doesn't.
-//  Mozilla 1.8 and WinIE 7 both accept the empty string, but neither accept a
-// whitespace-only string.
-//  We want to accept all the values that either of these browsers accept, but
-// not other values.
+//  Firefox 47 accepts all of the values in

[asanka, 2016/07/08 22:52:09]

At this point we should be keeping this list in sync with the spec instead of
specific versions of other browsers. Let's add a reference to the spec and drop
the comment about FF 47. Note that the spec explicitly calls out "User agents
must recognize all JavaScript MIME types", which is sufficient justification.

[Charlie Harrison, 2016/07/11 14:43:32]

Is the link to the whatwg spec not sufficient here? I've updated the comment.

[asanka, 2016/07/11 14:52:39]

Yup. That's sufficient.

To clarify, I was referring to the "FireFox 47 accepts all of the values in ..
so we should too" part. Both browsers are trying to be compliant with the spec
rather than trying to be compliant with each other. Same goes for CL
description.

+//  https://html.spec.whatwg.org/#javascript-mime-type, so we should too.
 const char* const kSupportedJavascriptTypes[] = {"text/javascript",

[asanka, 2016/07/08 22:52:09]

Sort to match spec.

[Charlie Harrison, 2016/07/11 14:43:32]

Done.

                                                  "text/ecmascript",
                                                  "application/javascript",
                                                  "application/ecmascript",
                                                  "application/x-javascript",
+                                                 "application/x-ecmascript",
+                                                 "text/javascript1.0",
                                                  "text/javascript1.1",
                                                  "text/javascript1.2",
                                                  "text/javascript1.3",
+                                                 "text/javascript1.4",
+                                                 "text/javascript1.5",
                                                  "text/jscript",
-                                                 "text/livescript"};
+                                                 "text/livescript",
+                                                 "text/x-ecmascript",
+                                                 "text/x-javascript"};
 
 // These types are excluded from the logic that allows all text/ types because
 // while they are technically text, it's very unlikely that a user expects to
 // see them rendered in text form.
 static const char* const kUnsupportedTextTypes[] = {
     "text/calendar",
     "text/x-calendar",
     "text/x-vcalendar",
     "text/vcalendar",
     "text/vcard",
@@ skipping 124 matching lines @@
 
 bool IsSupportedJavascriptMimeType(const std::string& mime_type) {
   return g_mime_util.Get().IsSupportedJavascriptMimeType(mime_type);
 }
 
 bool IsSupportedMimeType(const std::string& mime_type) {
   return g_mime_util.Get().IsSupportedMimeType(mime_type);
 }
 
 }  // namespace mime_util