Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: git_cl.py

Issue 213573004: Process first branch status request before spawning threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 1a1c64847f26c098dd292278249108de56e42980..32862686c0370439ef67371c910b551095f29f8b 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -1255,7 +1255,17 @@ def CMDstatus(parser, args):
color = Fore.BLUE
output.put((b, i, color))
- threads = [threading.Thread(target=fetch, args=(b,)) for b in branches]
+ # Process one branch synchronously to work through authentication, then
+ # spawn threads to process all the other branches in parallel.
+ first_branch = True
+ threads = []
+ for b in branches:
+ if first_branch:
+ fetch(b)
+ first_branch = False
+ else:
+ threads.append(threading.Thread(target=fetch, args=(b,)))
iannucci 2014/03/26 23:34:26 why not if branches: fetch(branches[0]) threa
Jason Robbins -- corp 2014/03/26 23:43:07 I had it that way until I realized that branches i
+
for t in threads:
t.daemon = True
t.start()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698