Process first branch status request before spawning threads.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld."""
 
 from distutils.version import LooseVersion
@@ skipping 1237 matching lines @@
         color = Fore.GREEN
       elif not msgs:
         # No message was sent.
         color = Fore.RED
       elif msgs[-1]['sender'] != props.get('owner_email'):
         color = Fore.YELLOW
       else:
         color = Fore.BLUE
       output.put((b, i, color))
 
-    threads = [threading.Thread(target=fetch, args=(b,)) for b in branches]
+    # Process one branch synchronously to work through authentication, then
+    # spawn threads to process all the other branches in parallel.
+    first_branch = True
+    threads = []
+    for b in branches:
+      if first_branch:
+        fetch(b)
+        first_branch = False
+      else:
+        threads.append(threading.Thread(target=fetch, args=(b,)))

[iannucci, 2014/03/26 23:34:26]

why not

if branches:
  fetch(branches[0])
  threads = [threading.Thread(target=fetch, args=(b,) for b in branches[1:]]

?

[Jason Robbins -- corp, 2014/03/26 23:43:07]

I had it that way until I realized that branches is a dictionary.   

If you like, I could go back to that by putting the list of the dictionary keys
in a new variable.  The variable naming seems awkward because the branches is
{branch: branch_url, ...}, sigh.

+
     for t in threads:
       t.daemon = True
       t.start()
   else:
     # Do not use GetApprovingReviewers(), since it requires an HTTP request.
     for b in branches:
       c = Changelist(branchref=b)
       url = c.GetIssueURL()
       output.put((b, url, Fore.BLUE if url else Fore.WHITE))
 
@@ skipping 1271 matching lines @@
         ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
           'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
 
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   colorama.init()
   sys.exit(main(sys.argv[1:]))