third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html - Issue 2135703002: [css-grid] Fix crash when using auto repeat for indefinite widths

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html

Issue 2135703002: [css-grid] Fix crash when using auto repeat for indefinite widths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html

diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html

new file mode 100644

index 0000000000000000000000000000000000000000..789844bdc3ef634e9399669596c462e738a25209

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html

@@ -0,0 +1,30 @@

+<!DOCTYPE HTML>

+<link href="resources/grid.css" rel="stylesheet">

+<link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel=stylesheet>

+<link href="../css-intrinsic-dimensions/resources/height-keyword-classes.css" rel=stylesheet>

+<style>

+.autoFill { grid: repeat(auto-fill, 100px) / repeat(auto-fill, 100px); }

+.autoFit { grid: repeat(auto-fit, 100px) / repeat(auto-fit, 100px); }

+</style>

+<script>

+if (window.testRunner)

+ testRunner.dumpAsText();

+</script>

+<div class="grid autoFill"><span></span></div>

+<div class="grid autoFit"><span></span></div>

Manuel Rego 2016/07/11 09:47:41 Nit: Are those <span> elements needed?

svillar1 2016/07/11 10:34:48 Not sure why I added them. Perhaps some initial te

+<div class="grid autoFill min-content"></div>

+<div class="grid autoFit min-content"></div>

+<div class="grid autoFill max-content"></div>

+<div class="grid autoFit max-content"></div>

+<div class="grid autoFill min-width-min-content min-height-min-content"></div>

+<div class="grid autoFit min-width-min-content min-height-min-content"></div>

+<div class="grid autoFill min-width-max-content min-height-max-content"></div>

+<div class="grid autoFit min-width-max-content min-height-max-content"></div>

+<p>This test has PASSED if it didn't CRASH.</p>

Manuel Rego 2016/07/11 09:47:41 Could you be little bit more descriptive about wha

svillar1 2016/07/11 10:34:48 Acknowledged.