third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html - Issue 2135703002: [css-grid] Fix crash when using auto repeat for indefinite widths

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html

Issue 2135703002: [css-grid] Fix crash when using auto repeat for indefinite widths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <link href="resources/grid.css" rel="stylesheet">

	3 <link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel =stylesheet>

	4 <link href="../css-intrinsic-dimensions/resources/height-keyword-classes.css" re l=stylesheet>

	5 <style>

	6 .autoFill { grid: repeat(auto-fill, 100px) / repeat(auto-fill, 100px); }

	7 .autoFit { grid: repeat(auto-fit, 100px) / repeat(auto-fit, 100px); }

	8 </style>

	9

	10 <script>

	11 if (window.testRunner)

	12 testRunner.dumpAsText();

	13 </script>

	14

	15 <div class="grid autoFill"><span></span></div>

	16 <div class="grid autoFit"><span></span></div>
	Manuel Rego 2016/07/11 09:47:41 Nit: Are those <span> elements needed? Nit: Are those <span> elements needed? svillar1 2016/07/11 10:34:48 Not sure why I added them. Perhaps some initial te Show quoted text On 2016/07/11 09:47:41, Manuel Rego wrote: > Nit: Are those <span> elements needed? Not sure why I added them. Perhaps some initial testing, I need to double-check though
	17

	18 <div class="grid autoFill min-content"></div>

	19 <div class="grid autoFit min-content"></div>

	20

	21 <div class="grid autoFill max-content"></div>

	22 <div class="grid autoFit max-content"></div>

	23

	24 <div class="grid autoFill min-width-min-content min-height-min-content"></div>

	25 <div class="grid autoFit min-width-min-content min-height-min-content"></div>

	26

	27 <div class="grid autoFill min-width-max-content min-height-max-content"></div>

	28 <div class="grid autoFit min-width-max-content min-height-max-content"></div>

	29

	30 <p>This test has PASSED if it didn't CRASH.</p>
	Manuel Rego 2016/07/11 09:47:41 Could you be little bit more descriptive about wha Could you be little bit more descriptive about what the test is checking? svillar1 2016/07/11 10:34:48 Acknowledged. Show quoted text On 2016/07/11 09:47:41, Manuel Rego wrote: > Could you be little bit more descriptive about what the test is checking? Acknowledged.
OLD	NEW