Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2135513002: Correctly handle reusing reset picture buffers. (Closed)

Created:
4 years, 5 months ago by jbauman
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Correctly handle reusing reset picture buffers. Pending output samples are marked as ready for reuse in DXVAVideoDecodeAccelerator::Reset. CopySurfaceComplete hasn't executed to acquire the keyed mutex, so it shouldn't be released. The incrementing of keyed_mutex_value_ also needs to be moved to someplace where it's certain that it will be executed even if CopySurfaceComplete is skipped. BUG=625564 Review-Url: https://codereview.chromium.org/2128663003 Cr-Commit-Position: refs/heads/master@{#403997} (cherry picked from commit d1e1331024f9e1fa5c633c0d29d6339c8e9fbe83) Committed: https://chromium.googlesource.com/chromium/src/+/34dae98bb2bcbd735d00d38c627478df4293aa8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M media/gpu/dxva_picture_buffer_win.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/gpu/dxva_picture_buffer_win.cc View 4 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jbauman
4 years, 5 months ago (2016-07-08 01:53:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
34dae98bb2bcbd735d00d38c627478df4293aa8b.

Powered by Google App Engine
This is Rietveld 408576698