Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2128663003: Correctly handle reusing reset picture buffers. (Closed)

Created:
4 years, 5 months ago by jbauman
Modified:
4 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly handle reusing reset picture buffers. Pending output samples are marked as ready for reuse in DXVAVideoDecodeAccelerator::Reset. CopySurfaceComplete hasn't executed to acquire the keyed mutex, so it shouldn't be released. The incrementing of keyed_mutex_value_ also needs to be moved to someplace where it's certain that it will be executed even if CopySurfaceComplete is skipped. BUG=625564 Committed: https://crrev.com/d1e1331024f9e1fa5c633c0d29d6339c8e9fbe83 Cr-Commit-Position: refs/heads/master@{#403997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M media/gpu/dxva_picture_buffer_win.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/gpu/dxva_picture_buffer_win.cc View 4 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbauman
4 years, 5 months ago (2016-07-06 23:52:23 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 5 months ago (2016-07-06 23:56:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128663003/1
4 years, 5 months ago (2016-07-07 00:02:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 00:08:15 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 00:08:34 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 00:09:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1e1331024f9e1fa5c633c0d29d6339c8e9fbe83
Cr-Commit-Position: refs/heads/master@{#403997}

Powered by Google App Engine
This is Rietveld 408576698