Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: src/lookup.cc

Issue 2135253002: [runtime] Follow-up fix for "Better encapsulation of dictionary objects handling in lookup iterator… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Test added Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-626715.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.cc
diff --git a/src/lookup.cc b/src/lookup.cc
index 544b164a8b7064d8769f4ade67bc567705cc01c2..4ab0a7f6ea84983241a70ea6ffe72bbafac30573 100644
--- a/src/lookup.cc
+++ b/src/lookup.cc
@@ -356,7 +356,11 @@ void LookupIterator::PrepareTransitionToDataProperty(
state_ = TRANSITION;
transition_ = transition;
- if (!transition->is_dictionary_map()) {
+ if (transition->is_dictionary_map()) {
+ // Don't set enumeration index (it will be set during value store).
+ property_details_ =
+ PropertyDetails(attributes, i::DATA, 0, PropertyCellType::kNoCell);
+ } else {
property_details_ = transition->GetLastDescriptorDetails();
has_property_ = true;
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-626715.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698