Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: src/lookup.cc

Issue 2135253002: [runtime] Follow-up fix for "Better encapsulation of dictionary objects handling in lookup iterator… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Test added Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-626715.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/lookup.h" 5 #include "src/lookup.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/deoptimizer.h" 8 #include "src/deoptimizer.h"
9 #include "src/elements.h" 9 #include "src/elements.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 transition_ = map; 349 transition_ = map;
350 } 350 }
351 return; 351 return;
352 } 352 }
353 353
354 Handle<Map> transition = 354 Handle<Map> transition =
355 Map::TransitionToDataProperty(map, name_, value, attributes, store_mode); 355 Map::TransitionToDataProperty(map, name_, value, attributes, store_mode);
356 state_ = TRANSITION; 356 state_ = TRANSITION;
357 transition_ = transition; 357 transition_ = transition;
358 358
359 if (!transition->is_dictionary_map()) { 359 if (transition->is_dictionary_map()) {
360 // Don't set enumeration index (it will be set during value store).
361 property_details_ =
362 PropertyDetails(attributes, i::DATA, 0, PropertyCellType::kNoCell);
363 } else {
360 property_details_ = transition->GetLastDescriptorDetails(); 364 property_details_ = transition->GetLastDescriptorDetails();
361 has_property_ = true; 365 has_property_ = true;
362 } 366 }
363 } 367 }
364 368
365 void LookupIterator::ApplyTransitionToDataProperty(Handle<JSObject> receiver) { 369 void LookupIterator::ApplyTransitionToDataProperty(Handle<JSObject> receiver) {
366 DCHECK_EQ(TRANSITION, state_); 370 DCHECK_EQ(TRANSITION, state_);
367 371
368 DCHECK(receiver.is_identical_to(GetStoreTarget())); 372 DCHECK(receiver.is_identical_to(GetStoreTarget()));
369 holder_ = receiver; 373 holder_ = receiver;
(...skipping 457 matching lines...) Expand 10 before | Expand all | Expand 10 after
827 : access_check_info->named_interceptor(); 831 : access_check_info->named_interceptor();
828 if (interceptor) { 832 if (interceptor) {
829 return handle(InterceptorInfo::cast(interceptor), isolate_); 833 return handle(InterceptorInfo::cast(interceptor), isolate_);
830 } 834 }
831 } 835 }
832 return Handle<InterceptorInfo>(); 836 return Handle<InterceptorInfo>();
833 } 837 }
834 838
835 } // namespace internal 839 } // namespace internal
836 } // namespace v8 840 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-626715.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698