Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2135253002: [runtime] Follow-up fix for "Better encapsulation of dictionary objects handling in lookup iterator… (Closed)

Created:
4 years, 5 months ago by Igor Sheludko
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Follow-up fix for "Better encapsulation of dictionary objects handling in lookup iterator." BUG=chromium:626715 Committed: https://crrev.com/b030a6f59d1f5a82b4d9c1ea53c4bfc844e71f68 Cr-Commit-Position: refs/heads/master@{#37651}

Patch Set 1 #

Patch Set 2 : Test added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M src/lookup.cc View 1 chunk +5 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-626715.js View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Igor Sheludko
PTAL
4 years, 5 months ago (2016-07-11 13:43:00 UTC) #4
Jakob Kummerow
LGTM. Thanks for the testcase :-)
4 years, 5 months ago (2016-07-11 15:46:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135253002/20001
4 years, 5 months ago (2016-07-11 15:47:00 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 15:48:58 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 15:52:08 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b030a6f59d1f5a82b4d9c1ea53c4bfc844e71f68
Cr-Commit-Position: refs/heads/master@{#37651}

Powered by Google App Engine
This is Rietveld 408576698