Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2135133003: Make Website hashable so it can be deduplicated. (Closed)

Created:
4 years, 5 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Theresa
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Website hashable so it can be deduplicated. This change prevents duplicate entries from appearing in the website list when the by-origin and by-host site lists are merged. BUG=430999, 601627 Committed: https://crrev.com/4ac11035813e3829bb7eef3a022807b8ffc0b758 Cr-Commit-Position: refs/heads/master@{#404778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -70 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java View 3 chunks +67 lines, -66 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 5 months ago (2016-07-12 00:22:34 UTC) #3
Theresa
lgtm
4 years, 5 months ago (2016-07-12 01:01:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135133003/1
4 years, 5 months ago (2016-07-12 01:09:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 04:08:30 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 04:08:50 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 04:10:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ac11035813e3829bb7eef3a022807b8ffc0b758
Cr-Commit-Position: refs/heads/master@{#404778}

Powered by Google App Engine
This is Rietveld 408576698