Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java

Issue 2135133003: Make Website hashable so it can be deduplicated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java
index 3dd72b5b70cb9fb2de27c122f504e57aff595b2b..8641b0591a16a72b669c3e8d55f9a92fd4d2e779 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java
@@ -29,13 +29,9 @@ public class WebsitePermissionsFetcher {
}
// This is a 1 <--> 1..N mapping between origin and Website.
- // TODO(mvanouwerkerk): The Website class has no equals or hashCode methods so storing them in
- // a HashSet is really confusing to readers of this code. There is no deduplication at all.
private final Map<String, Set<Website>> mSitesByOrigin = new HashMap<>();
// This is a 1 <--> 1..N mapping between host and Website.
- // TODO(mvanouwerkerk): The Website class has no equals or hashCode methods so storing them in
- // a HashSet is really confusing to readers of this code. There is no deduplication at all.
private final Map<String, Set<Website>> mSitesByHost = new HashMap<>();
// The callback to run when the permissions have been fetched.
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698