Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2135103003: Storage manager: Show the disk usage of other users. (Closed)

Created:
4 years, 5 months ago by fukino
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Storage manager: Show the disk usage of other users. This CL adds an item "Other users" on the storage manager, which shows the total disk size used by other users. Cryptohome API was added by https://chromium-review.googlesource.com/#/c/356641 BUG=591958 TEST=manually tested on link/minnie CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation TBR=dbeam@chromium.org Review-Url: https://codereview.chromium.org/2111043003 Cr-Commit-Position: refs/heads/master@{#403393} (cherry picked from commit 1717bcb71c4e34c4dbef814afbca83e21049dba7) Committed: https://chromium.googlesource.com/chromium/src/+/a954edd289c69b89d330cf42f95c3d99eaa8a02f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -1 line) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos/storage_manager.html View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos/storage_manager.js View 3 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h View 3 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc View 5 chunks +39 lines, -0 lines 0 comments Download
M chromeos/cryptohome/homedir_methods.h View 3 chunks +10 lines, -0 lines 0 comments Download
M chromeos/cryptohome/homedir_methods.cc View 2 chunks +32 lines, -0 lines 0 comments Download
M chromeos/cryptohome/mock_homedir_methods.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/dbus/cryptohome_client.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/dbus/cryptohome_client.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_cryptohome_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_cryptohome_client.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chromeos/dbus/mock_cryptohome_client.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fukino
4 years, 5 months ago (2016-07-11 08:24:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a954edd289c69b89d330cf42f95c3d99eaa8a02f.

Powered by Google App Engine
This is Rietveld 408576698