Storage manager: Show the disk usage of other users.

Storage manager: Show the disk usage of other users.

This CL adds an item "Other users" on the storage manager, which shows the total
disk size used by other users.
Cryptohome API was added by https://chromium-review.googlesource.com/#/c/356641

BUG=591958
TEST=manually tested on link/minnie
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7
Cr-Commit-Position: refs/heads/master@{#403393}

[fukino, 2016-06-30 12:30:19]

Description was changed from

==========
Storage manager: Show the disk usage of other users.

This CL adds an item "Other users" on the storage manager, which shows the total
disk size used by other users.
Cryptohome API was added by https://chromium-review.googlesource.com/#/c/356641

BUG=591958
TEST=manually tested on link/minnie
==========

to

==========
Storage manager: Show the disk usage of other users.

This CL adds an item "Other users" on the storage manager, which shows the total
disk size used by other users.
Cryptohome API was added by https://chromium-review.googlesource.com/#/c/356641

BUG=591958
TEST=manually tested on link/minnie
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-06-30 13:06:28]

fukino@chromium.org changed reviewers:
+ dbeam@chromium.org, dkrahn@chromium.org

[fukino, 2016-06-30 13:06:28]

dkrahn@: Could you take a look at chromeos/?
dbeam@: Could you take a look at chrome/?
Thank you!

[Darren Krahn, 2016-06-30 16:35:26]

chromeos/ lgtm

https://codereview.chromium.org/2111043003/diff/20001/chromeos/dbus/fake_cryp...
File chromeos/dbus/fake_cryptohome_client.cc (right):

https://codereview.chromium.org/2111043003/diff/20001/chromeos/dbus/fake_cryp...
chromeos/dbus/fake_cryptohome_client.cc:111: cryptohome::BaseReply reply;
Create the extension and return a fake size?

[fukino, 2016-06-30 18:54:37]

https://codereview.chromium.org/2111043003/diff/20001/chromeos/dbus/fake_cryp...
File chromeos/dbus/fake_cryptohome_client.cc (right):

https://codereview.chromium.org/2111043003/diff/20001/chromeos/dbus/fake_cryp...
chromeos/dbus/fake_cryptohome_client.cc:111: cryptohome::BaseReply reply;
On 2016/06/30 16:35:26, Darren Krahn wrote:
> Create the extension and return a fake size?

I set 100MB as a fake usage for each user. Thanks!

[Dan Beam, 2016-06-30 23:24:09]

lgtm

https://codereview.chromium.org/2111043003/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h (right):

https://codereview.chromium.org/2111043003/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h:7: 
#include <stddef.h>
#include <vector>

https://codereview.chromium.org/2111043003/diff/60001/chromeos/cryptohome/hom...
File chromeos/cryptohome/homedir_methods.cc (right):

https://codereview.chromium.org/2111043003/diff/60001/chromeos/cryptohome/hom...
chromeos/cryptohome/homedir_methods.cc:420: bool result,
why does |result| exist?

https://codereview.chromium.org/2111043003/diff/60001/chromeos/cryptohome/hom...
File chromeos/cryptohome/homedir_methods.h (right):

https://codereview.chromium.org/2111043003/diff/60001/chromeos/cryptohome/hom...
chromeos/cryptohome/homedir_methods.h:33: typedef base::Callback<void(bool
success, int64_t size)>
nit: #include <stddef.h> for int64_t

[fukino, 2016-06-30 23:59:03]

Thank you!

https://codereview.chromium.org/2111043003/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h (right):

https://codereview.chromium.org/2111043003/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h:7: 
On 2016/06/30 23:24:09, Dan Beam wrote:
> #include <stddef.h>
> #include <vector>

Done.
Included stdint.h for int64_t.

https://codereview.chromium.org/2111043003/diff/60001/chromeos/cryptohome/hom...
File chromeos/cryptohome/homedir_methods.cc (right):

https://codereview.chromium.org/2111043003/diff/60001/chromeos/cryptohome/hom...
chromeos/cryptohome/homedir_methods.cc:420: bool result,
On 2016/06/30 23:24:09, Dan Beam wrote:
> why does |result| exist?

I actually not sure how the |result| in ProtobufMethodCallback should be
treated.
I followed other similar functions, like OnMountExCallback above.

https://codereview.chromium.org/2111043003/diff/60001/chromeos/cryptohome/hom...
File chromeos/cryptohome/homedir_methods.h (right):

https://codereview.chromium.org/2111043003/diff/60001/chromeos/cryptohome/hom...
chromeos/cryptohome/homedir_methods.h:33: typedef base::Callback<void(bool
success, int64_t size)>
On 2016/06/30 23:24:09, Dan Beam wrote:
> nit: #include <stddef.h> for int64_t

Done.

[fukino, 2016-06-30 23:59:51]

The CQ bit was checked by fukino@chromium.org

[fukino, 2016-06-30 23:59:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dkrahn@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2111043003/#ps80001
(title: "Add necessary headers.")

[commit-bot: I haz the power, 2016-07-01 00:00:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 00:32:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 00:32:18]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[fukino, 2016-07-01 01:59:22]

The CQ bit was checked by fukino@chromium.org

[fukino, 2016-07-01 01:59:22]

The patchset sent to the CQ was uploaded after l-g-t-m from dkrahn@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2111043003/#ps100001
(title: "Fix typo and the order of storage items.")

[commit-bot: I haz the power, 2016-07-01 01:59:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 02:35:49]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-01 02:35:54]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 02:37:15]

Description was changed from

==========
Storage manager: Show the disk usage of other users.

This CL adds an item "Other users" on the storage manager, which shows the total
disk size used by other users.
Cryptohome API was added by https://chromium-review.googlesource.com/#/c/356641

BUG=591958
TEST=manually tested on link/minnie
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Storage manager: Show the disk usage of other users.

This CL adds an item "Other users" on the storage manager, which shows the total
disk size used by other users.
Cryptohome API was added by https://chromium-review.googlesource.com/#/c/356641

BUG=591958
TEST=manually tested on link/minnie
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7
Cr-Commit-Position: refs/heads/master@{#403393}
==========

[commit-bot: I haz the power, 2016-07-01 02:37:16]

Patchset 6 (id:??) landed as
https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7
Cr-Commit-Position: refs/heads/master@{#403393}