Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2139)

Issue 2134863002: mac: Crash on uncaught Objective-C exceptions routed to NSApplication (Closed)

Created:
4 years, 5 months ago by Mark Mentovai
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

mac: Crash on uncaught Objective-C exceptions routed to NSApplication -[NSApplication reportException:] accepts an NSException* which it logs via NSLog(), and then takes one of these actions: 1. Immediate intentional crash. 2. Swallow the exception and return. 3. Show a dialog that lets the user choose between 1 and 2. The only option that makes sense to Chrome is (1), an immediate intentional crash, which can be achieved by setting the NSApplicationCrashOnExceptions user default to YES. Do this early in application startup. BUG=624885 Review-Url: https://codereview.chromium.org/2112553009 Cr-Commit-Position: refs/heads/master@{#403545} (cherry picked from commit b296d953fe840f3cdf609bde2dc3de53baabae63) Committed: https://chromium.googlesource.com/chromium/src/+/04a5635ba9f304e4dcbaeb11d42175573988d25b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/browser/chrome_browser_main_mac.mm View 1 chunk +0 lines, -8 lines 0 comments Download
M content/app/mac/mac_init.mm View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Mark Mentovai
4 years, 5 months ago (2016-07-08 21:01:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
04a5635ba9f304e4dcbaeb11d42175573988d25b.

Powered by Google App Engine
This is Rietveld 408576698