mac: Crash on uncaught Objective-C exceptions routed to NSApplication

mac: Crash on uncaught Objective-C exceptions routed to NSApplication

-[NSApplication reportException:] accepts an NSException* which it
logs via NSLog(), and then takes one of these actions:
 1. Immediate intentional crash.
 2. Swallow the exception and return.
 3. Show a dialog that lets the user choose between 1 and 2.

The only option that makes sense to Chrome is (1), an immediate
intentional crash, which can be achieved by setting the
NSApplicationCrashOnExceptions user default to YES. Do this early in
application startup.

BUG=624885
Committed: https://crrev.com/b296d953fe840f3cdf609bde2dc3de53baabae63
Cr-Commit-Position: refs/heads/master@{#403545}

[Mark Mentovai, 2016-07-01 21:07:21]

mark@chromium.org changed reviewers:
+ avi@chromium.org

[Mark Mentovai, 2016-07-01 21:07:22]

https://codereview.chromium.org/2112553009/diff/1/content/app/mac/mac_init.mm
File content/app/mac/mac_init.mm (right):

https://codereview.chromium.org/2112553009/diff/1/content/app/mac/mac_init.mm...
content/app/mac/mac_init.mm:22: // looks like a mistake, but the value really is
supposed to be a string.
I double-checked this comment and it’s still true.

[Avi (use Gerrit), 2016-07-01 21:10:34]

lgtm

[Mark Mentovai, 2016-07-01 21:13:18]

The CQ bit was checked by mark@chromium.org

[Mark Mentovai, 2016-07-01 21:13:19]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2112553009/#ps20001
(title: "Self-review")

[commit-bot: I haz the power, 2016-07-01 21:13:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 22:05:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-01 22:05:02]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 22:07:00]

Description was changed from

==========
mac: Crash on uncaught Objective-C exceptions routed to NSApplication

-[NSApplication reportException:] accepts an NSException* which it
logs via NSLog(), and then takes one of these actions:
 1. Immediate intentional crash.
 2. Swallow the exception and return.
 3. Show a dialog that lets the user choose between 1 and 2.

The only option that makes sense to Chrome is (1), an immediate
intentional crash, which can be achieved by setting the
NSApplicationCrashOnExceptions user default to YES. Do this early in
application startup.

BUG=624885
==========

to

==========
mac: Crash on uncaught Objective-C exceptions routed to NSApplication

-[NSApplication reportException:] accepts an NSException* which it
logs via NSLog(), and then takes one of these actions:
 1. Immediate intentional crash.
 2. Swallow the exception and return.
 3. Show a dialog that lets the user choose between 1 and 2.

The only option that makes sense to Chrome is (1), an immediate
intentional crash, which can be achieved by setting the
NSApplicationCrashOnExceptions user default to YES. Do this early in
application startup.

BUG=624885

Committed: https://crrev.com/b296d953fe840f3cdf609bde2dc3de53baabae63
Cr-Commit-Position: refs/heads/master@{#403545}
==========

[commit-bot: I haz the power, 2016-07-01 22:07:00]

Patchset 2 (id:??) landed as
https://crrev.com/b296d953fe840f3cdf609bde2dc3de53baabae63
Cr-Commit-Position: refs/heads/master@{#403545}