Implement ConstantSourceNode

Implement ConstantSourceNode

Add implementation of ConstantSourceNode, including a factory method
and a constructor.

This serves as a very useful constant source node, and, because it has
an AudioParam, it can be used as a constructible AudioParam.

Feature: https://www.chromestatus.com/features/5647701588836352
Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/9uoSMZftWfY/GJaqkCUNAAAJ
Spec: https://webaudio.github.io/web-audio-api/#ConstantSourceNode

BUG=644438
TEST=constant-source-basic.html, constant-source-output.html

Committed: https://crrev.com/f61f1e00fc29d3e88ef4e3d7b1c63d5b469d92f2
Cr-Commit-Position: refs/heads/master@{#425184}

[Raymond Toy, 2016-09-06 20:39:38]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 20:40:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 22:04:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 22:04:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Raymond Toy, 2016-09-07 20:04:44]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 20:05:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 20:09:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 20:09:27]

Dry run: Exceeded global retry quota

[Raymond Toy, 2016-09-14 18:24:08]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 18:24:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 21:15:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 21:15:06]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raymond Toy, 2016-09-28 19:02:38]

Description was changed from

==========
Implement ConstantSourceNode

Add implementation of ConstantSourceNode, including a create method
and a constructor.

BUG=
TEST=
==========

to

==========
Implement ConstantSourceNode

Add implementation of ConstantSourceNode, including a create method
and a constructor.

BUG=644438
TEST=constant-source-basic.html, constant-source-output.html
==========

[Raymond Toy, 2016-09-28 20:10:41]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 20:11:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 21:22:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 21:22:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Raymond Toy, 2016-09-29 16:57:08]

Description was changed from

==========
Implement ConstantSourceNode

Add implementation of ConstantSourceNode, including a create method
and a constructor.

BUG=644438
TEST=constant-source-basic.html, constant-source-output.html
==========

to

==========
Implement ConstantSourceNode

Add implementation of ConstantSourceNode, including a create method
and a constructor.

Feature: https://www.chromestatus.com/features/5647701588836352
Intent: https://www.chromestatus.com/features/5647701588836352

BUG=644438
TEST=constant-source-basic.html, constant-source-output.html
==========

[Raymond Toy, 2016-09-30 16:06:46]

Description was changed from

==========
Implement ConstantSourceNode

Add implementation of ConstantSourceNode, including a create method
and a constructor.

Feature: https://www.chromestatus.com/features/5647701588836352
Intent: https://www.chromestatus.com/features/5647701588836352

BUG=644438
TEST=constant-source-basic.html, constant-source-output.html
==========

to

==========
Implement ConstantSourceNode

Add implementation of ConstantSourceNode, including a create method
and a constructor.

Feature: https://www.chromestatus.com/features/5647701588836352
Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/9uoSMZftWfY/GJaqkCUN...

BUG=644438
TEST=constant-source-basic.html, constant-source-output.html
==========

[Raymond Toy, 2016-09-30 16:08:20]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 16:08:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raymond Toy, 2016-09-30 16:09:35]

Description was changed from

==========
Implement ConstantSourceNode

Add implementation of ConstantSourceNode, including a create method
and a constructor.

Feature: https://www.chromestatus.com/features/5647701588836352
Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/9uoSMZftWfY/GJaqkCUN...

BUG=644438
TEST=constant-source-basic.html, constant-source-output.html
==========

to

==========
Implement ConstantSourceNode

Add implementation of ConstantSourceNode, including a factory method
and a constructor.

This serves as a very useful constant source node, and, because it has
an AudioParam, it can be used as a constructible AudioParam.

Feature: https://www.chromestatus.com/features/5647701588836352
Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/9uoSMZftWfY/GJaqkCUN...

BUG=644438
TEST=constant-source-basic.html, constant-source-output.html
==========

[Raymond Toy, 2016-09-30 16:09:56]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-09-30 16:09:58]

PTAL

[Raymond Toy, 2016-09-30 16:24:30]

https://codereview.chromium.org/2134813002/diff/340001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webaudio/constant-source-onended.html
(right):

https://codereview.chromium.org/2134813002/diff/340001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/constant-source-onended.html:21:
audit.defineTask("onended", function (taskDone) {
Maybe we don't want to use Audit for this?

[commit-bot: I haz the power, 2016-09-30 17:53:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 17:53:53]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2016-10-05 15:22:51]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 15:23:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raymond Toy, 2016-10-05 15:23:31]

Ping. Should I get another reviewer?

[commit-bot: I haz the power, 2016-10-05 18:44:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 18:44:37]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hongchan, 2016-10-06 18:10:23]

lgtm

lgtm with some nits in layout tests.

https://codereview.chromium.org/2134813002/diff/380001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webaudio/constant-source-onended.html
(right):

https://codereview.chromium.org/2134813002/diff/380001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/constant-source-onended.html:32:
tester.done();
This and taskDone() at the bottom. Which one ends first? Can you guarantee their
order without using suspend()?
I think we need to make sure tester.don() ends first no matter what.

https://codereview.chromium.org/2134813002/diff/380001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webaudio/constant-source-output.html
(right):

https://codereview.chromium.org/2134813002/diff/380001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/constant-source-output.html:33:
Should("ConstantSourceNode({offset: 0.5})", actual).beEqualToArray(expected);
wrap this line.

https://codereview.chromium.org/2134813002/diff/380001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/constant-source-output.html:101: var
expected = createLinearRampArray(0, rampEndTime, 0.5, 1, context.sampleRate);
wrap line.

https://codereview.chromium.org/2134813002/diff/380001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/constant-source-output.html:154: success
= Should("ConstantSourceNode frames [0, " + sourceStartFrame + ")",
wrap line.

[Raymond Toy, 2016-10-07 15:24:07]

https://codereview.chromium.org/2134813002/diff/380001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webaudio/constant-source-onended.html
(right):

https://codereview.chromium.org/2134813002/diff/380001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/constant-source-onended.html:32:
tester.done();
On 2016/10/06 18:10:23, hoch wrote:
> This and taskDone() at the bottom. Which one ends first? Can you guarantee
their
> order without using suspend()?
> I think we need to make sure tester.don() ends first no matter what.

Yeah, I think we should just not use Audit here in favor of plain testharness.

[Raymond Toy, 2016-10-07 15:49:10]

https://codereview.chromium.org/2134813002/diff/380001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webaudio/constant-source-output.html
(right):

https://codereview.chromium.org/2134813002/diff/380001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/constant-source-output.html:33:
Should("ConstantSourceNode({offset: 0.5})", actual).beEqualToArray(expected);
On 2016/10/06 18:10:23, hoch wrote:
> wrap this line.

Done.

https://codereview.chromium.org/2134813002/diff/380001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/constant-source-output.html:101: var
expected = createLinearRampArray(0, rampEndTime, 0.5, 1, context.sampleRate);
On 2016/10/06 18:10:23, hoch wrote:
> wrap line.

Done.

https://codereview.chromium.org/2134813002/diff/380001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/constant-source-output.html:154: success
= Should("ConstantSourceNode frames [0, " + sourceStartFrame + ")",
On 2016/10/06 18:10:23, hoch wrote:
> wrap line.

Done.

[Raymond Toy, 2016-10-07 18:07:27]

Description was changed from

==========
Implement ConstantSourceNode

Add implementation of ConstantSourceNode, including a factory method
and a constructor.

This serves as a very useful constant source node, and, because it has
an AudioParam, it can be used as a constructible AudioParam.

Feature: https://www.chromestatus.com/features/5647701588836352
Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/9uoSMZftWfY/GJaqkCUN...

BUG=644438
TEST=constant-source-basic.html, constant-source-output.html
==========

to

==========
Implement ConstantSourceNode

Add implementation of ConstantSourceNode, including a factory method
and a constructor.

This serves as a very useful constant source node, and, because it has
an AudioParam, it can be used as a constructible AudioParam.

Feature: https://www.chromestatus.com/features/5647701588836352
Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/9uoSMZftWfY/GJaqkCUN...
Spec: https://webaudio.github.io/web-audio-api/#ConstantSourceNode

BUG=644438
TEST=constant-source-basic.html, constant-source-output.html
==========

[Raymond Toy, 2016-10-10 15:37:05]

rtoy@chromium.org changed reviewers:
+ tkent@chromium.org

[Raymond Toy, 2016-10-10 15:37:06]

tkent@ PTAL as API owner

[tkent, 2016-10-11 13:58:43]

https://codereview.chromium.org/2134813002/diff/400001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/modules.gypi (right):

https://codereview.chromium.org/2134813002/diff/400001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/modules.gypi:1: {
I guess you added this file by mistake.

[Raymond Toy, 2016-10-11 16:30:13]

On 2016/10/11 13:58:43, tkent wrote:
>
https://codereview.chromium.org/2134813002/diff/400001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/modules/modules.gypi (right):
> 
>
https://codereview.chromium.org/2134813002/diff/400001/third_party/WebKit/Sou...
> third_party/WebKit/Source/modules/modules.gypi:1: {
> I guess you added this file by mistake.

Oops. It used to be required, but has been removed recently.

Fixed.

[Raymond Toy, 2016-10-11 16:30:31]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 16:30:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 16:33:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 16:33:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2016-10-11 22:22:36]

lgtm

[Raymond Toy, 2016-10-12 15:13:03]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-10-12 15:13:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org, tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2134813002/#ps440001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-12 15:13:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 15:25:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 15:25:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Raymond Toy, 2016-10-12 15:44:59]

rtoy@chromium.org changed reviewers:
+ isherman@chromium.org

[Raymond Toy, 2016-10-12 15:45:00]

isherman@ PTAL at histograms.xml changes.

[Ilya Sherman, 2016-10-13 00:37:38]

histograms.xml lgtm

[Raymond Toy, 2016-10-13 14:55:44]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-10-13 14:56:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 15:05:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 15:05:17]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Raymond Toy, 2016-10-13 15:22:17]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-10-13 15:22:17]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
isherman@chromium.org, hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2134813002/#ps460001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-13 15:22:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 19:09:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 19:09:37]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raymond Toy, 2016-10-13 20:24:32]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-10-13 20:24:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 22:14:56]

Description was changed from

==========
Implement ConstantSourceNode

Add implementation of ConstantSourceNode, including a factory method
and a constructor.

This serves as a very useful constant source node, and, because it has
an AudioParam, it can be used as a constructible AudioParam.

Feature: https://www.chromestatus.com/features/5647701588836352
Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/9uoSMZftWfY/GJaqkCUN...
Spec: https://webaudio.github.io/web-audio-api/#ConstantSourceNode

BUG=644438
TEST=constant-source-basic.html, constant-source-output.html
==========

to

==========
Implement ConstantSourceNode

Add implementation of ConstantSourceNode, including a factory method
and a constructor.

This serves as a very useful constant source node, and, because it has
an AudioParam, it can be used as a constructible AudioParam.

Feature: https://www.chromestatus.com/features/5647701588836352
Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/9uoSMZftWfY/GJaqkCUN...
Spec: https://webaudio.github.io/web-audio-api/#ConstantSourceNode

BUG=644438
TEST=constant-source-basic.html, constant-source-output.html
==========

[commit-bot: I haz the power, 2016-10-13 22:14:59]

Committed patchset #24 (id:460001)

[commit-bot: I haz the power, 2016-10-13 22:16:45]

Description was changed from

==========
Implement ConstantSourceNode

Add implementation of ConstantSourceNode, including a factory method
and a constructor.

This serves as a very useful constant source node, and, because it has
an AudioParam, it can be used as a constructible AudioParam.

Feature: https://www.chromestatus.com/features/5647701588836352
Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/9uoSMZftWfY/GJaqkCUN...
Spec: https://webaudio.github.io/web-audio-api/#ConstantSourceNode

BUG=644438
TEST=constant-source-basic.html, constant-source-output.html
==========

to

==========
Implement ConstantSourceNode

Add implementation of ConstantSourceNode, including a factory method
and a constructor.

This serves as a very useful constant source node, and, because it has
an AudioParam, it can be used as a constructible AudioParam.

Feature: https://www.chromestatus.com/features/5647701588836352
Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/9uoSMZftWfY/GJaqkCUN...
Spec: https://webaudio.github.io/web-audio-api/#ConstantSourceNode

BUG=644438
TEST=constant-source-basic.html, constant-source-output.html

Committed: https://crrev.com/f61f1e00fc29d3e88ef4e3d7b1c63d5b469d92f2
Cr-Commit-Position: refs/heads/master@{#425184}
==========

[commit-bot: I haz the power, 2016-10-13 22:16:47]

Patchset 24 (id:??) landed as
https://crrev.com/f61f1e00fc29d3e88ef4e3d7b1c63d5b469d92f2
Cr-Commit-Position: refs/heads/master@{#425184}