Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2134703002:
[Interpreter] Support Linux perf >= 4.1 in linux_perf_report.py. (Closed)
|
Created:
4 years, 5 months ago by Stefano Sanfilippo Modified:
4 years, 5 months ago Reviewers:
rmcilroy CC:
v8-reviews_googlegroups.com, Michael Achenbach Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Interpreter] Support Linux perf >= 4.1 in linux_perf_report.py.
Since Linux 4.1, flag -f became -F, but the long option --flags stayed
the same. Using --flags assures compatibility with new and old versions.
Also, symbols appear to be reported as name+offset in newer versions
even when not requested, so we trim the latter part if present.
BUG=v8:4899
LOG=N
Committed: https://crrev.com/c9fedd252c3853650e2dc0ca70d1502e93118ed8
Cr-Commit-Position: refs/heads/master@{#37614}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add comment. #Messages
Total messages: 21 (15 generated)
Description was changed from ========== [Interpreter] Make linux_perf_report.py support more versions of perf. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, in some cases symbols are reported as name+offset, so that last part needs to be trimmed if present. BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Make linux_perf_report.py support more versions of perf. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset even if it was not requested, so that last part needs to be trimmed if present. BUG=v8:4899 LOG=N ==========
Description was changed from ========== [Interpreter] Make linux_perf_report.py support more versions of perf. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset even if it was not requested, so that last part needs to be trimmed if present. BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Make linux_perf_report.py support more versions of perf. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset in newer versions even when not requested, so we make sure that the second part is trimmed if present. BUG=v8:4899 LOG=N ==========
Description was changed from ========== [Interpreter] Make linux_perf_report.py support more versions of perf. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset in newer versions even when not requested, so we make sure that the second part is trimmed if present. BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Make linux_perf_report.py support more versions of perf. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset in newer versions even when not requested, so we make sure the second part is trimmed if present. BUG=v8:4899 LOG=N ==========
Description was changed from ========== [Interpreter] Make linux_perf_report.py support more versions of perf. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset in newer versions even when not requested, so we make sure the second part is trimmed if present. BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Make linux_perf_report.py support more versions of perf. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset in newer versions even when not requested, so we trim the latter part if present. BUG=v8:4899 LOG=N ==========
Description was changed from ========== [Interpreter] Make linux_perf_report.py support more versions of perf. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset in newer versions even when not requested, so we trim the latter part if present. BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Add support for Linux perf >= 4.1 in linux_perf_report.py. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset in newer versions even when not requested, so we trim the latter part if present. BUG=v8:4899 LOG=N ==========
Description was changed from ========== [Interpreter] Add support for Linux perf >= 4.1 in linux_perf_report.py. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset in newer versions even when not requested, so we trim the latter part if present. BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Support Linux perf >= 4.1 in linux_perf_report.py. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset in newer versions even when not requested, so we trim the latter part if present. BUG=v8:4899 LOG=N ==========
ssanfilippo@chromium.org changed reviewers: + rmcilroy@chromium.org
PTAL.
The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM, thanks. https://codereview.chromium.org/2134703002/diff/1/tools/ignition/linux_perf_r... File tools/ignition/linux_perf_report.py (right): https://codereview.chromium.org/2134703002/diff/1/tools/ignition/linux_perf_r... tools/ignition/linux_perf_report.py:100: symbol = line.split(" ", 1)[1].split("+", 1)[0] nit - add a comment on that the split("+... part is removing the symbol offset if it exists.
https://codereview.chromium.org/2134703002/diff/1/tools/ignition/linux_perf_r... File tools/ignition/linux_perf_report.py (right): https://codereview.chromium.org/2134703002/diff/1/tools/ignition/linux_perf_r... tools/ignition/linux_perf_report.py:100: symbol = line.split(" ", 1)[1].split("+", 1)[0] On 2016/07/08 15:17:57, rmcilroy wrote: > nit - add a comment on that the split("+... part is removing the symbol offset > if it exists. Done.
The CQ bit was checked by ssanfilippo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rmcilroy@chromium.org Link to the patchset: https://codereview.chromium.org/2134703002/#ps20001 (title: "Add comment.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Support Linux perf >= 4.1 in linux_perf_report.py. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset in newer versions even when not requested, so we trim the latter part if present. BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Support Linux perf >= 4.1 in linux_perf_report.py. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset in newer versions even when not requested, so we trim the latter part if present. BUG=v8:4899 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Support Linux perf >= 4.1 in linux_perf_report.py. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset in newer versions even when not requested, so we trim the latter part if present. BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Support Linux perf >= 4.1 in linux_perf_report.py. Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset in newer versions even when not requested, so we trim the latter part if present. BUG=v8:4899 LOG=N Committed: https://crrev.com/c9fedd252c3853650e2dc0ca70d1502e93118ed8 Cr-Commit-Position: refs/heads/master@{#37614} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c9fedd252c3853650e2dc0ca70d1502e93118ed8 Cr-Commit-Position: refs/heads/master@{#37614} |
