Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: tools/ignition/linux_perf_report.py

Issue 2134703002: [Interpreter] Support Linux perf >= 4.1 in linux_perf_report.py. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add comment. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/ignition/linux_perf_report.py
diff --git a/tools/ignition/linux_perf_report.py b/tools/ignition/linux_perf_report.py
index fbf562c2abe9b699de7feb47b09446c90c9b19a2..eaf85b3f91efd21dd62fa5ba9d78d559a6e3fab6 100755
--- a/tools/ignition/linux_perf_report.py
+++ b/tools/ignition/linux_perf_report.py
@@ -97,7 +97,8 @@ def collapsed_callchains_generator(perf_stream, show_all=False,
if skip_until_end_of_chain:
continue
- symbol = line.split(" ", 1)[1]
+ # Trim the leading address and the trailing +offset, if present.
+ symbol = line.split(" ", 1)[1].split("+", 1)[0]
if not show_full_signatures:
symbol = strip_function_parameters(symbol)
current_chain.append(symbol)
@@ -204,7 +205,7 @@ def parse_command_line():
def main():
program_options = parse_command_line()
- perf = subprocess.Popen(["perf", "script", "-f", "ip,sym",
+ perf = subprocess.Popen(["perf", "script", "--fields", "ip,sym",
"-i", program_options.perf_filename],
stdout=subprocess.PIPE)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698