base/third_party/libevent/README.chromium - Issue 2134603002: Fix a logic bug in kqueue.c.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/third_party/libevent/README.chromium

Issue 2134603002: Fix a logic bug in kqueue.c. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name: libevent	1 Name: libevent
	Mark Mentovai 2016/07/08 11:15:02 CL description: since this also fixes bug 620259, CL description: since this also fixes bug 620259, add that to the BUG line. erikchen 2016/07/08 15:20:06 Done. Show quoted text On 2016/07/08 11:15:02, Mark Mentovai wrote: > CL description: since this also fixes bug 620259, add that to the BUG line. Done.
2 URL: http://libevent.org/	2 URL: http://libevent.org/

3 Version: 1.4.15	3 Version: 1.4.15

4 License: BSD	4 License: BSD

5 Security Critical: yes	5 Security Critical: yes

6	6

7 Local Modifications:	7 Local Modifications:

8 Rather than use libevent's own build system, we just build a Chrome	8 Rather than use libevent's own build system, we just build a Chrome

9 static library using GYP.	9 static library using GYP.

10	10

11 1) Run configure and "make event-config.h" on Linux, FreeBSD, Solaris,	11 1) Run configure and "make event-config.h" on Linux, FreeBSD, Solaris,

(...skipping 16 matching lines...) Expand all Loading...
28 4) The directories WIN32-Code and WIN32-Prj are not included.	28 4) The directories WIN32-Code and WIN32-Prj are not included.

29 5) The configs for android were copied from Linux's which were very close to	29 5) The configs for android were copied from Linux's which were very close to

30 android one with the exception of HAVE_FD_MASK and HAVE_STRLCPY.	30 android one with the exception of HAVE_FD_MASK and HAVE_STRLCPY.

31 6) Add files to support building with the PNaCl toolchain. Added	31 6) Add files to support building with the PNaCl toolchain. Added

32 libevent_nacl_nonsfi.gyp for build rule. nacl_nonsfi/config.h and	32 libevent_nacl_nonsfi.gyp for build rule. nacl_nonsfi/config.h and

33 nacl_nonsfi/event-config.h are derived from linux/ counterparts.	33 nacl_nonsfi/event-config.h are derived from linux/ counterparts.

34 nacl_nonsfi/random.c is also added to provide the random() function,	34 nacl_nonsfi/random.c is also added to provide the random() function,

35 which is missing in the newlib-based PNaCl toolchain.	35 which is missing in the newlib-based PNaCl toolchain.

36 7) Stub out signal.c for nacl_helper_nonsfi. socketpair() will be prohibited	36 7) Stub out signal.c for nacl_helper_nonsfi. socketpair() will be prohibited

37 by sandbox in nacl_helper_nonsfi.	37 by sandbox in nacl_helper_nonsfi.

	38 8) Fix a logic bug in kqueue.c where struct kevent::flags was being directly

	39 compared against EV_ERROR rather than using a bit mask.

OLD	NEW

« no previous file with comments | « no previous file | base/third_party/libevent/kqueue.c » ('j') | base/third_party/libevent/kqueue.c » ('J')