SELECT element: Remove optionIndex argument of HTMLSelectElement::selectOption().

SELECT element: Remove optionIndex argument of HTMLSelectElement::selectOption().

selectOption() doesn't need optionIndex now.  So this CL removes the optionIndex
argument of selectOption(), and removes a selectOption(optionIndex, flags) variant.

Existing callsites of selectOption(optionIndex, flags) are updated:
 - If a callsite knows HTMLOptionElement pointed by the optionIndex, the
   HTMLOptionElement should be passed to selectOption().
 - If not, we use HTMLSelectElement::item(optionIndex) to get an
   HTMLOptionElement pointer.

This CL improves performance because we skip to calculate optionIndex from an
HTMLOptionElement in some cases.

blink_perf.dom:
select-multiple-add: 1553 runs/s -> 1787 runs/s
select-single-add: 801 runs/s -> 940 runs/s
select-single-remove: 135 runs/s -> 146 runs/s

BUG=577989
Committed: https://crrev.com/cd9026f15fb5741f7c263cadb803cf707d438780
Cr-Commit-Position: refs/heads/master@{#404317}

[tkent, 2016-07-08 01:51:53]

Description was changed from

==========
SLECT element: Remove optionIndex argument of HTMLSelectElement::selectOption().

selectOption() doesn't need optionIndex now.  So this CL removes the optionIndex
argument of selectOption(), and removes a selectOption(optionIndex, falgs)
variant.

Exising allsites of selectOption(optionIndex, falgs) are updated:
 - If a callsite knows HTMLOptionElement pointed by the optionIndex, the
   HTMLoptionElement should be passed to selectOption().
 - If not, we use HTMLSelectElement::item(optionIndex) to get an
   HTMLOptionElement pointer.

This CL improves performance becaus we skip to calculate optionIndex from an
HTMLOptionElement in some cases.

blink_perf.dom:
select-multiple-add: 1553 runs/s -> 1787 runs/s
select-single-add: 801 runs/s -> 940 runs/s
select-single-remove: 135 runs/s -> 146 runs/s

BUG=577989
==========

to

==========
SLECT element: Remove optionIndex argument of HTMLSelectElement::selectOption().

selectOption() doesn't need optionIndex now.  So this CL removes the optionIndex
argument of selectOption(), and removes a selectOption(optionIndex, flags)
variant.

Existing callsites of selectOption(optionIndex, flags) are updated:
 - If a callsite knows HTMLOptionElement pointed by the optionIndex, the
   HTMLOptionElement should be passed to selectOption().
 - If not, we use HTMLSelectElement::item(optionIndex) to get an
   HTMLOptionElement pointer.

This CL improves performance because we skip to calculate optionIndex from an
HTMLOptionElement in some cases.

blink_perf.dom:
select-multiple-add: 1553 runs/s -> 1787 runs/s
select-single-add: 801 runs/s -> 940 runs/s
select-single-remove: 135 runs/s -> 146 runs/s

BUG=577989
==========

[tkent, 2016-07-08 02:33:01]

Description was changed from

==========
SLECT element: Remove optionIndex argument of HTMLSelectElement::selectOption().

selectOption() doesn't need optionIndex now.  So this CL removes the optionIndex
argument of selectOption(), and removes a selectOption(optionIndex, flags)
variant.

Existing callsites of selectOption(optionIndex, flags) are updated:
 - If a callsite knows HTMLOptionElement pointed by the optionIndex, the
   HTMLOptionElement should be passed to selectOption().
 - If not, we use HTMLSelectElement::item(optionIndex) to get an
   HTMLOptionElement pointer.

This CL improves performance because we skip to calculate optionIndex from an
HTMLOptionElement in some cases.

blink_perf.dom:
select-multiple-add: 1553 runs/s -> 1787 runs/s
select-single-add: 801 runs/s -> 940 runs/s
select-single-remove: 135 runs/s -> 146 runs/s

BUG=577989
==========

to

==========
SELECT element: Remove optionIndex argument of
HTMLSelectElement::selectOption().

selectOption() doesn't need optionIndex now.  So this CL removes the optionIndex
argument of selectOption(), and removes a selectOption(optionIndex, flags)
variant.

Existing callsites of selectOption(optionIndex, flags) are updated:
 - If a callsite knows HTMLOptionElement pointed by the optionIndex, the
   HTMLOptionElement should be passed to selectOption().
 - If not, we use HTMLSelectElement::item(optionIndex) to get an
   HTMLOptionElement pointer.

This CL improves performance because we skip to calculate optionIndex from an
HTMLOptionElement in some cases.

blink_perf.dom:
select-multiple-add: 1553 runs/s -> 1787 runs/s
select-single-add: 801 runs/s -> 940 runs/s
select-single-remove: 135 runs/s -> 146 runs/s

BUG=577989
==========

[tkent, 2016-07-08 03:09:37]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2016-07-08 03:09:38]

Keishi-san, would you review this please?

[keishi, 2016-07-08 04:16:02]

LGTM

[tkent, 2016-07-08 04:23:06]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-07-08 04:23:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 09:26:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-08 09:26:51]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 09:29:47]

Description was changed from

==========
SELECT element: Remove optionIndex argument of
HTMLSelectElement::selectOption().

selectOption() doesn't need optionIndex now.  So this CL removes the optionIndex
argument of selectOption(), and removes a selectOption(optionIndex, flags)
variant.

Existing callsites of selectOption(optionIndex, flags) are updated:
 - If a callsite knows HTMLOptionElement pointed by the optionIndex, the
   HTMLOptionElement should be passed to selectOption().
 - If not, we use HTMLSelectElement::item(optionIndex) to get an
   HTMLOptionElement pointer.

This CL improves performance because we skip to calculate optionIndex from an
HTMLOptionElement in some cases.

blink_perf.dom:
select-multiple-add: 1553 runs/s -> 1787 runs/s
select-single-add: 801 runs/s -> 940 runs/s
select-single-remove: 135 runs/s -> 146 runs/s

BUG=577989
==========

to

==========
SELECT element: Remove optionIndex argument of
HTMLSelectElement::selectOption().

selectOption() doesn't need optionIndex now.  So this CL removes the optionIndex
argument of selectOption(), and removes a selectOption(optionIndex, flags)
variant.

Existing callsites of selectOption(optionIndex, flags) are updated:
 - If a callsite knows HTMLOptionElement pointed by the optionIndex, the
   HTMLOptionElement should be passed to selectOption().
 - If not, we use HTMLSelectElement::item(optionIndex) to get an
   HTMLOptionElement pointer.

This CL improves performance because we skip to calculate optionIndex from an
HTMLOptionElement in some cases.

blink_perf.dom:
select-multiple-add: 1553 runs/s -> 1787 runs/s
select-single-add: 801 runs/s -> 940 runs/s
select-single-remove: 135 runs/s -> 146 runs/s

BUG=577989

Committed: https://crrev.com/cd9026f15fb5741f7c263cadb803cf707d438780
Cr-Commit-Position: refs/heads/master@{#404317}
==========

[commit-bot: I haz the power, 2016-07-08 09:29:47]

Patchset 1 (id:??) landed as
https://crrev.com/cd9026f15fb5741f7c263cadb803cf707d438780
Cr-Commit-Position: refs/heads/master@{#404317}