third_party/WebKit/Source/core/html/HTMLSelectElement.h - Issue 2134553002: SELECT element: Remove optionIndex argument of HTMLSelectElement::selectOption().

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.h

Issue 2134553002: SELECT element: Remove optionIndex argument of HTMLSelectElement::selectOption(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).	2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).

3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

4 * (C) 1999 Antti Koivisto (koivisto@kde.org)	4 * (C) 1999 Antti Koivisto (koivisto@kde.org)

5 * (C) 2000 Dirk Mueller (mueller@kde.org)	5 * (C) 2000 Dirk Mueller (mueller@kde.org)

6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.	6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.

7 * Copyright (C) 2010 Google Inc. All rights reserved.	7 * Copyright (C) 2010 Google Inc. All rights reserved.

8 *	8 *

9 * This library is free software; you can redistribute it and/or	9 * This library is free software; you can redistribute it and/or

10 * modify it under the terms of the GNU Library General Public	10 * modify it under the terms of the GNU Library General Public

(...skipping 211 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
222 bool isRequiredFormControl() const override;	222 bool isRequiredFormControl() const override;

223	223

224 bool hasPlaceholderLabelOption() const;	224 bool hasPlaceholderLabelOption() const;

225	225

226 enum SelectOptionFlag {	226 enum SelectOptionFlag {

227 DeselectOtherOptions = 1 << 0,	227 DeselectOtherOptions = 1 << 0,

228 DispatchInputAndChangeEvent = 1 << 1,	228 DispatchInputAndChangeEvent = 1 << 1,

229 MakeOptionDirty = 1 << 2,	229 MakeOptionDirty = 1 << 2,

230 };	230 };

231 typedef unsigned SelectOptionFlags;	231 typedef unsigned SelectOptionFlags;

232 void selectOption(int optionIndex, SelectOptionFlags);

233 void selectOption(HTMLOptionElement*, SelectOptionFlags);	232 void selectOption(HTMLOptionElement*, SelectOptionFlags);

234 void selectOption(HTMLOptionElement*, int optionIndex, SelectOptionFlags);

235 void deselectItemsWithoutValidation(HTMLElement* elementToExclude = 0);	233 void deselectItemsWithoutValidation(HTMLElement* elementToExclude = 0);

236 void parseMultipleAttribute(const AtomicString&);	234 void parseMultipleAttribute(const AtomicString&);

237 HTMLOptionElement* lastSelectedOption() const;	235 HTMLOptionElement* lastSelectedOption() const;

238 void updateSelectedState(HTMLOptionElement*, bool multi, bool shift);	236 void updateSelectedState(HTMLOptionElement*, bool multi, bool shift);

239 void menuListDefaultEventHandler(Event*);	237 void menuListDefaultEventHandler(Event*);

240 void handlePopupOpenKeyboardEvent(Event*);	238 void handlePopupOpenKeyboardEvent(Event*);

241 bool shouldOpenPopupForKeyDownEvent(KeyboardEvent*);	239 bool shouldOpenPopupForKeyDownEvent(KeyboardEvent*);

242 bool shouldOpenPopupForKeyPressEvent(KeyboardEvent*);	240 bool shouldOpenPopupForKeyPressEvent(KeyboardEvent*);

243 void listBoxDefaultEventHandler(Event*);	241 void listBoxDefaultEventHandler(Event*);

244 void setOptionsChangedOnLayoutObject();	242 void setOptionsChangedOnLayoutObject();

(...skipping 52 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
297	295

298 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, FirstSelectableOption);	296 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, FirstSelectableOption);

299 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, LastSelectableOption);	297 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, LastSelectableOption);

300 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, NextSelectableOption);	298 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, NextSelectableOption);

301 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, PreviousSelectableOption);	299 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, PreviousSelectableOption);

302 };	300 };

303	301

304 } // namespace blink	302 } // namespace blink

305	303

306 #endif // HTMLSelectElement_h	304 #endif // HTMLSelectElement_h

OLD	NEW