Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2134533002: Reland of Link to DirectWrite directly, instead of calling LoadLibrary (Closed)

Created:
4 years, 5 months ago by Ilya Kulshin
Modified:
4 years, 4 months ago
Reviewers:
jam, scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Link to DirectWrite directly, instead of calling LoadLibrary (patchset #1 id:1 of https://codereview.chromium.org/2127313002/ ) Reason for revert: Attempting, yet again, to reland the original change. Original issue's description: > Revert of Link to DirectWrite directly, instead of calling LoadLibrary (patchset #4 id:290001 of https://codereview.chromium.org/2111373002/ ) > > Reason for revert: > Breaks https://build.chromium.org/p/chromium.win/builders/Win8%20GYP/builds/430 > > Original issue's description: > > Reland of Link to DirectWrite directly, instead of calling LoadLibrary (patchset #1 id:1 of https://codereview.chromium.org/2117683002/ ) > > > > Reason for revert: > > Attempting to reland original change. > > > > Original issue's description: > > > Revert of Link to DirectWrite directly, instead of calling LoadLibrary (patchset #8 id:180001 of https://codereview.chromium.org/2029343002/ ) > > > > > > Reason for revert: > > > Breaks aura_demo target > > > > > > Original issue's description: > > > > Link to DirectWrite directly, instead of calling LoadLibrary > > > > > > > > BUG= > > > > > > > > Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07 > > > > Cr-Commit-Position: refs/heads/master@{#403344} > > > > > > TBR=scottmg@chromium.org,jam@chromium.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > BUG= > > > > > > Committed: https://crrev.com/d825ab07a72e8440c0d1b77464eef5d8740a7258 > > > Cr-Commit-Position: refs/heads/master@{#403379} > > > > BUG= > > TBR=jam@chromium.org > > > > Committed: https://crrev.com/ceb58c4b801e325292f37d3a60b9378ac92a6955 > > Cr-Commit-Position: refs/heads/master@{#404268} > > TBR=scottmg@chromium.org,jam@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > BUG= > > Committed: https://crrev.com/4a1eba3116f1cbc409b83aac547c52778d89bcb3 > Cr-Commit-Position: refs/heads/master@{#404278} BUG= Committed: https://crrev.com/99aa1722463f6eb9d3e39c9d3f9721cb4ddb7584 Cr-Commit-Position: refs/heads/master@{#410452}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix views_unittests #

Patch Set 4 : Exclude gyp files #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -105 lines) Patch
M content/child/BUILD.gn View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc View 1 2 3 1 chunk +3 lines, -23 lines 0 comments Download
M content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc View 1 2 3 13 chunks +2 lines, -42 lines 0 comments Download
M content/child/dwrite_font_proxy/font_fallback_win_unittest.cc View 1 2 chunks +2 lines, -17 lines 0 comments Download
M content/test/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M ui/gfx/font_fallback_win.cc View 1 2 3 2 chunks +3 lines, -6 lines 0 comments Download
M ui/gfx/win/direct_write.cc View 1 1 chunk +6 lines, -16 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Ilya Kulshin
Created Reland of Link to DirectWrite directly, instead of calling LoadLibrary
4 years, 5 months ago (2016-07-08 00:42:41 UTC) #1
jam
lgtm but please remove the NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true lines. no need to skip the CQ
4 years, 5 months ago (2016-07-09 02:18:24 UTC) #2
Ilya Kulshin
Now that we've dropped the requirement to keep GYP builds running, I'm trying to land ...
4 years, 4 months ago (2016-08-03 19:30:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134533002/390001
4 years, 4 months ago (2016-08-08 20:03:51 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:390001)
4 years, 4 months ago (2016-08-08 20:51:15 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 20:53:09 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/99aa1722463f6eb9d3e39c9d3f9721cb4ddb7584
Cr-Commit-Position: refs/heads/master@{#410452}

Powered by Google App Engine
This is Rietveld 408576698