chrome/android/java/res/layout/usb_permission.xml - Issue 2134463002: Add USB device permissions to individual site settings on Android.

Unified Diff: chrome/android/java/res/layout/usb_permission.xml

Issue 2134463002: Add USB device permissions to individual site settings on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Presubmits. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/settings_usb.png ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/UsbPermission.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/usb_permission.xml

diff --git a/chrome/android/java/res/layout/clear_storage.xml b/chrome/android/java/res/layout/usb_permission.xml

similarity index 71%

copy from chrome/android/java/res/layout/clear_storage.xml

copy to chrome/android/java/res/layout/usb_permission.xml

index 7a3a587d84fc71e64e9f486a113a101ba8e39b1a..36d10c772e5142564443eb72d1e4269c7909ce88 100644

--- a/chrome/android/java/res/layout/clear_storage.xml

+++ b/chrome/android/java/res/layout/usb_permission.xml

@@ -1,5 +1,5 @@

<?xml version="1.0" encoding="utf-8"?>

Use of this source code is governed by a BSD-style license that can be

found in the LICENSE file. -->

@@ -8,6 +8,5 @@

xmlns:chrome="http://schemas.android.com/apk/res-auto"

android:layout_width="wrap_content"

android:layout_height="wrap_content"

Theresa 2016/07/13 00:11:58 This should have an android:contentDescription so

Reilly Grant (use Gerrit) 2016/07/13 00:45:18 Done.

- android:contentDescription="@string/webstorage_clear_data_dialog_title"

- android:src="@drawable/btn_trash"

+ android:src="@drawable/btn_close"

chrome:tint="@color/blue_mode_tint"/>

Theresa 2016/07/13 00:11:58 Is the 'x' supposed to be blue? iirc, in the mocks

Reilly Grant (use Gerrit) 2016/07/13 00:45:18 Fixed.