chrome/android/java/res/layout/usb_permission.xml - Issue 2134463002: Add USB device permissions to individual site settings on Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/usb_permission.xml

Issue 2134463002: Add USB device permissions to individual site settings on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Presubmits. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/settings_usb.png ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/UsbPermission.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <org.chromium.chrome.browser.widget.TintedImageView	6 <org.chromium.chrome.browser.widget.TintedImageView

7 xmlns:android="http://schemas.android.com/apk/res/android"	7 xmlns:android="http://schemas.android.com/apk/res/android"

8 xmlns:chrome="http://schemas.android.com/apk/res-auto"	8 xmlns:chrome="http://schemas.android.com/apk/res-auto"

9 android:layout_width="wrap_content"	9 android:layout_width="wrap_content"

10 android:layout_height="wrap_content"	10 android:layout_height="wrap_content"
	Theresa 2016/07/13 00:11:58 This should have an android:contentDescription so This should have an android:contentDescription so that when accessibility mode is turned out something meaningful is read out rather than "Button 456729". Reilly Grant (use Gerrit) 2016/07/13 00:45:18 Done. Show quoted text On 2016/07/13 at 00:11:58, Theresa Wellington wrote: > This should have an android:contentDescription so that when accessibility mode is turned out something meaningful is read out rather than "Button 456729". Done.
11 android:contentDescription="@string/webstorage_clear_data_dialog_title"	11 android:src="@drawable/btn_close"

12 android:src="@drawable/btn_trash"

13 chrome:tint="@color/blue_mode_tint"/>	12 chrome:tint="@color/blue_mode_tint"/>
	Theresa 2016/07/13 00:11:58 Is the 'x' supposed to be blue? iirc, in the mocks Is the 'x' supposed to be blue? iirc, in the mocks it was grey. As an aside, can you please include a link to the mocks in one of the bugs and screenshots of the in-flight CL? Reilly Grant (use Gerrit) 2016/07/13 00:45:18 Fixed. Show quoted text On 2016/07/13 at 00:11:58, Theresa Wellington wrote: > Is the 'x' supposed to be blue? iirc, in the mocks it was grey. Fixed. Show quoted text > As an aside, can you please include a link to the mocks in one of the bugs and screenshots of the in-flight CL? Added a screenshot to crbug.com/601627.
OLD	NEW