Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: content/browser/devtools/worker_devtools_manager.cc

Issue 213423008: Add pause_on_start flag to WorkerProcessMsg_CreateWorker_Params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/worker_devtools_manager.cc
diff --git a/content/browser/devtools/worker_devtools_manager.cc b/content/browser/devtools/worker_devtools_manager.cc
index 00735f34c2ebfe69744a2fb44fb261bd4b230872..119392dda203c80b34713d7200b395da3c2227fd 100644
--- a/content/browser/devtools/worker_devtools_manager.cc
+++ b/content/browser/devtools/worker_devtools_manager.cc
@@ -236,8 +236,6 @@ void WorkerDevToolsManager::WorkerCreated(
if (instance.Matches(it->worker_url, it->worker_name,
instance.partition(),
instance.resource_context())) {
- worker->Send(new DevToolsAgentMsg_PauseWorkerContextOnStart(
- instance.worker_route_id()));
WorkerId new_worker_id(worker->GetData().id, instance.worker_route_id());
paused_workers_[new_worker_id] = it->old_worker_id;
terminated_workers_.erase(it);
@@ -282,6 +280,22 @@ void WorkerDevToolsManager::WorkerContextStarted(WorkerProcessHost* process,
paused_workers_.erase(it);
}
+bool WorkerDevToolsManager::TerminatedWorkerExist(
yurys 2014/03/27 08:37:26 We could merge WorkerCreated into this new method
horo 2014/03/27 09:48:10 Done.
+ const WorkerProcessHost::WorkerInstance& instance) const {
+ for (TerminatedInspectedWorkers::const_iterator it =
+ terminated_workers_.begin();
+ it != terminated_workers_.end();
+ ++it) {
+ if (instance.Matches(it->worker_url,
+ it->worker_name,
+ instance.partition(),
+ instance.resource_context())) {
+ return true;
+ }
+ }
+ return false;
+}
kinuko 2014/03/27 08:04:34 I think adding pause_on_start param in CreateWorke
horo 2014/03/27 09:45:48 Done.
+
void WorkerDevToolsManager::RemoveInspectedWorkerData(
const WorkerId& id) {
for (TerminatedInspectedWorkers::iterator it = terminated_workers_.begin();
« no previous file with comments | « content/browser/devtools/worker_devtools_manager.h ('k') | content/browser/worker_host/worker_process_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698