Add pause_on_start flag to WorkerProcessMsg_CreateWorker_Params.

content/browser/devtools/worker_devtools_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/worker_devtools_manager.h"
 
 #include <list>
 #include <map>
 
 #include "base/bind.h"
@@ skipping 218 matching lines @@
 }
 
 void WorkerDevToolsManager::WorkerCreated(
     WorkerProcessHost* worker,
     const WorkerProcessHost::WorkerInstance& instance) {
   for (TerminatedInspectedWorkers::iterator it = terminated_workers_.begin();
        it != terminated_workers_.end(); ++it) {
     if (instance.Matches(it->worker_url, it->worker_name,
                          instance.partition(),
                          instance.resource_context())) {
-      worker->Send(new DevToolsAgentMsg_PauseWorkerContextOnStart(
-          instance.worker_route_id()));
       WorkerId new_worker_id(worker->GetData().id, instance.worker_route_id());
       paused_workers_[new_worker_id] = it->old_worker_id;
       terminated_workers_.erase(it);
       return;
     }
   }
 }
 
 void WorkerDevToolsManager::WorkerDestroyed(
     WorkerProcessHost* worker,
@@ skipping 24 matching lines @@
 
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(
           &DetachedClientHosts::WorkerReloaded,
           it->second,
           new_worker_id));
   paused_workers_.erase(it);
 }
 
+bool WorkerDevToolsManager::TerminatedWorkerExist(

[yurys, 2014/03/27 08:37:26]

We could merge WorkerCreated into this new method to make it clear why the
worker is now in paused_workers_ map.

[horo, 2014/03/27 09:48:10]

Done.

+    const WorkerProcessHost::WorkerInstance& instance) const {
+  for (TerminatedInspectedWorkers::const_iterator it =
+           terminated_workers_.begin();
+       it != terminated_workers_.end();
+       ++it) {
+    if (instance.Matches(it->worker_url,
+                         it->worker_name,
+                         instance.partition(),
+                         instance.resource_context())) {
+      return true;
+    }
+  }
+  return false;
+}

[kinuko, 2014/03/27 08:04:34]

I think adding pause_on_start param in CreateWorker message makes sense, but
when we move DevToolsManager to solely on UI thread this simple sync method
needs to be handled asynchronously-- will we have an async method like void
TerminatedWorkerExist(const Callback<void(bool)>& callback) in the new
architecture then?

[horo, 2014/03/27 09:45:48]

Done.

+
 void WorkerDevToolsManager::RemoveInspectedWorkerData(
     const WorkerId& id) {
   for (TerminatedInspectedWorkers::iterator it = terminated_workers_.begin();
        it != terminated_workers_.end(); ++it) {
     if (it->old_worker_id == id) {
       terminated_workers_.erase(it);
       return;
     }
   }
 
@@ skipping 143 matching lines @@
     process->Send(new DevToolsAgentMsg_ResumeWorkerContext(id.second));
 }
 
 WorkerDevToolsManager::WorkerDevToolsAgentHost::~WorkerDevToolsAgentHost() {
   DetachedClientHosts::RemovePendingWorkerData(worker_id_);
   g_agent_map.Get().erase(worker_id_);
   g_orphan_map.Get().erase(worker_id_);
 }
 
 }  // namespace content