Issue 213413010: Use RegisterSize to count the pushq size and the argument slot size from JS to C++

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 213413010: Use RegisterSize to count the pushq size and the argument slot size from JS to C++ (Closed)

Created:
6 years, 9 months ago by haitao.feng

Modified:
6 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Use RegisterSize to count the pushq size and the argument slot size from JS to C++ R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20317

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -31 lines)			Patch
M	src/x64/frames-x64.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/x64/regexp-macro-assembler-x64.h	View	2 chunks	+23 lines, -22 lines	0 comments	Download
M	src/x64/regexp-macro-assembler-x64.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

haitao.feng

PTAL. Currently they are the last RegisterSize occurrences we need to update for x32.

6 years, 9 months ago (2014-03-27 09:43:04 UTC) #1

haitao.feng

6 years, 8 months ago (2014-03-28 00:35:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20317 (presubmit successful).