Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: src/x64/regexp-macro-assembler-x64.cc

Issue 213413010: Use RegisterSize to count the pushq size and the argument slot size from JS to C++ (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/regexp-macro-assembler-x64.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 674 matching lines...) Expand 10 before | Expand all | Expand 10 after
685 __ movq(Operand(rbp, kStartIndex), rdx); // Passed as int32 in edx. 685 __ movq(Operand(rbp, kStartIndex), rdx); // Passed as int32 in edx.
686 __ movq(Operand(rbp, kInputStart), r8); 686 __ movq(Operand(rbp, kInputStart), r8);
687 __ movq(Operand(rbp, kInputEnd), r9); 687 __ movq(Operand(rbp, kInputEnd), r9);
688 // Callee-save on Win64. 688 // Callee-save on Win64.
689 __ pushq(rsi); 689 __ pushq(rsi);
690 __ pushq(rdi); 690 __ pushq(rdi);
691 __ pushq(rbx); 691 __ pushq(rbx);
692 #else 692 #else
693 // GCC passes arguments in rdi, rsi, rdx, rcx, r8, r9 (and then on stack). 693 // GCC passes arguments in rdi, rsi, rdx, rcx, r8, r9 (and then on stack).
694 // Push register parameters on stack for reference. 694 // Push register parameters on stack for reference.
695 ASSERT_EQ(kInputString, -1 * kPointerSize); 695 ASSERT_EQ(kInputString, -1 * kRegisterSize);
696 ASSERT_EQ(kStartIndex, -2 * kPointerSize); 696 ASSERT_EQ(kStartIndex, -2 * kRegisterSize);
697 ASSERT_EQ(kInputStart, -3 * kPointerSize); 697 ASSERT_EQ(kInputStart, -3 * kRegisterSize);
698 ASSERT_EQ(kInputEnd, -4 * kPointerSize); 698 ASSERT_EQ(kInputEnd, -4 * kRegisterSize);
699 ASSERT_EQ(kRegisterOutput, -5 * kPointerSize); 699 ASSERT_EQ(kRegisterOutput, -5 * kRegisterSize);
700 ASSERT_EQ(kNumOutputRegisters, -6 * kPointerSize); 700 ASSERT_EQ(kNumOutputRegisters, -6 * kRegisterSize);
701 __ pushq(rdi); 701 __ pushq(rdi);
702 __ pushq(rsi); 702 __ pushq(rsi);
703 __ pushq(rdx); 703 __ pushq(rdx);
704 __ pushq(rcx); 704 __ pushq(rcx);
705 __ pushq(r8); 705 __ pushq(r8);
706 __ pushq(r9); 706 __ pushq(r9);
707 707
708 __ pushq(rbx); // Callee-save 708 __ pushq(rbx); // Callee-save
709 #endif 709 #endif
710 710
(...skipping 728 matching lines...) Expand 10 before | Expand all | Expand 10 after
1439 } 1439 }
1440 } 1440 }
1441 1441
1442 #undef __ 1442 #undef __
1443 1443
1444 #endif // V8_INTERPRETED_REGEXP 1444 #endif // V8_INTERPRETED_REGEXP
1445 1445
1446 }} // namespace v8::internal 1446 }} // namespace v8::internal
1447 1447
1448 #endif // V8_TARGET_ARCH_X64 1448 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/regexp-macro-assembler-x64.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698