[builtins] Show builtin frames in PrintStack()

[builtins] Show builtin frames in PrintStack()

Builtin frames can simply use the existing JavaScriptFrame::Print
method. Builtin exit frames need their own implementation which can print
the function name, receiver and parameters.

R=bmeurer@chromium.org, yangguo@chromium.org
BUG=

Committed: https://crrev.com/a99155871938a4bd41a4c9c2837ac560d864666e
Cr-Commit-Position: refs/heads/master@{#37644}

[jgruber, 2016-07-11 09:02:29]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 09:02:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 09:29:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 09:29:13]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-07-11 10:02:09]

Description was changed from

==========
[builtins] Show builtin frames in PrintStack()

Builtin frames can simply use the existing JavaScriptFrame::Print
method. Builtin exit frames need their implementation which can print
the function name, receiver and parameters.

R=bmeurer@chromium.org, yangguo@chromium.org
BUG=
==========

to

==========
[builtins] Show builtin frames in PrintStack()

Builtin frames can simply use the existing JavaScriptFrame::Print
method. Builtin exit frames need their own implementation which can print
the function name, receiver and parameters.

R=bmeurer@chromium.org, yangguo@chromium.org
BUG=
==========

[Yang, 2016-07-11 10:24:32]

lgtm

https://codereview.chromium.org/2134093002/diff/1/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/2134093002/diff/1/src/frames.cc#newcode691
src/frames.cc:691: int parameters_count = ComputeParametersCount();
Let's only print up to, let's say, 5 parameters.

[Yang, 2016-07-11 10:24:54]

On 2016/07/11 10:24:32, Yang wrote:
> lgtm
> 
> https://codereview.chromium.org/2134093002/diff/1/src/frames.cc
> File src/frames.cc (right):
> 
> https://codereview.chromium.org/2134093002/diff/1/src/frames.cc#newcode691
> src/frames.cc:691: int parameters_count = ComputeParametersCount();
> Let's only print up to, let's say, 5 parameters.

Ignore this comment. I just saw that we don't have this limitation for JS frames
either.

[jgruber, 2016-07-11 10:39:14]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 10:39:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-07-11 10:53:16]

lgtm.

[commit-bot: I haz the power, 2016-07-11 11:13:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 11:13:35]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-07-11 12:56:53]

LGTM.

[jgruber, 2016-07-11 13:25:49]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-07-11 13:25:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 13:27:54]

Description was changed from

==========
[builtins] Show builtin frames in PrintStack()

Builtin frames can simply use the existing JavaScriptFrame::Print
method. Builtin exit frames need their own implementation which can print
the function name, receiver and parameters.

R=bmeurer@chromium.org, yangguo@chromium.org
BUG=
==========

to

==========
[builtins] Show builtin frames in PrintStack()

Builtin frames can simply use the existing JavaScriptFrame::Print
method. Builtin exit frames need their own implementation which can print
the function name, receiver and parameters.

R=bmeurer@chromium.org, yangguo@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-07-11 13:27:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-11 13:29:07]

Description was changed from

==========
[builtins] Show builtin frames in PrintStack()

Builtin frames can simply use the existing JavaScriptFrame::Print
method. Builtin exit frames need their own implementation which can print
the function name, receiver and parameters.

R=bmeurer@chromium.org, yangguo@chromium.org
BUG=
==========

to

==========
[builtins] Show builtin frames in PrintStack()

Builtin frames can simply use the existing JavaScriptFrame::Print
method. Builtin exit frames need their own implementation which can print
the function name, receiver and parameters.

R=bmeurer@chromium.org, yangguo@chromium.org
BUG=

Committed: https://crrev.com/a99155871938a4bd41a4c9c2837ac560d864666e
Cr-Commit-Position: refs/heads/master@{#37644}
==========

[commit-bot: I haz the power, 2016-07-11 13:29:10]

Patchset 2 (id:??) landed as
https://crrev.com/a99155871938a4bd41a4c9c2837ac560d864666e
Cr-Commit-Position: refs/heads/master@{#37644}