Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: src/frames-inl.h

Issue 2134093002: [builtins] Show builtin frames in PrintStack() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Print frame kind Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/frames.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames-inl.h
diff --git a/src/frames-inl.h b/src/frames-inl.h
index bc2ff4fb6a8b5d74d57bec9e667af00c6b6f18db..77784b823459e478139363da86cd462e64782cf3 100644
--- a/src/frames-inl.h
+++ b/src/frames-inl.h
@@ -101,22 +101,13 @@ inline ExitFrame::ExitFrame(StackFrameIteratorBase* iterator)
inline BuiltinExitFrame::BuiltinExitFrame(StackFrameIteratorBase* iterator)
: ExitFrame(iterator) {}
-inline Object* BuiltinExitFrame::target_slot_object() const {
- return Memory::Object_at(fp() + BuiltinExitFrameConstants::kTargetOffset);
-}
-
-inline Object* BuiltinExitFrame::new_target_slot_object() const {
- return Memory::Object_at(fp() + BuiltinExitFrameConstants::kNewTargetOffset);
-}
-
inline Object* BuiltinExitFrame::receiver_slot_object() const {
// The receiver is the first argument on the frame.
// fp[1]: return address.
// fp[2]: the last argument (new target).
// fp[4]: argc.
// fp[2 + argc - 1]: receiver.
- Object* argc_slot =
- Memory::Object_at(fp() + BuiltinExitFrameConstants::kArgcOffset);
+ Object* argc_slot = argc_slot_object();
DCHECK(argc_slot->IsSmi());
int argc = Smi::cast(argc_slot)->value();
@@ -125,6 +116,18 @@ inline Object* BuiltinExitFrame::receiver_slot_object() const {
return Memory::Object_at(fp() + receiverOffset);
}
+inline Object* BuiltinExitFrame::argc_slot_object() const {
+ return Memory::Object_at(fp() + BuiltinExitFrameConstants::kArgcOffset);
+}
+
+inline Object* BuiltinExitFrame::target_slot_object() const {
+ return Memory::Object_at(fp() + BuiltinExitFrameConstants::kTargetOffset);
+}
+
+inline Object* BuiltinExitFrame::new_target_slot_object() const {
+ return Memory::Object_at(fp() + BuiltinExitFrameConstants::kNewTargetOffset);
+}
+
inline StandardFrame::StandardFrame(StackFrameIteratorBase* iterator)
: StackFrame(iterator) {
}
« no previous file with comments | « src/frames.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698