third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp - Issue 2134033002: Remove PageLifecycleObserver::didCommitLoad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp

Issue 2134033002: Remove PageLifecycleObserver::didCommitLoad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp

diff --git a/third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp b/third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp

index 6805f9af80063b561328d8b247700d05c01db32c..96d5207ad7d8aad31468b9dc88d0009d2fcd2fa5 100644

--- a/third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp

+++ b/third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp

@@ -37,11 +37,4 @@ void PageLifecycleNotifier::notifyPageVisibilityChanged()

observer->pageVisibilityChanged();

}

-void PageLifecycleNotifier::notifyDidCommitLoad(LocalFrame* frame)

- TemporaryChange<IterationState> scope(m_iterationState, AllowingNone);

- for (PageLifecycleObserver* observer : m_observers)

- observer->didCommitLoad(frame);

} // namespace blink