third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp - Issue 2134033002: Remove PageLifecycleObserver::didCommitLoad

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp

Issue 2134033002: Remove PageLifecycleObserver::didCommitLoad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/PageLifecycleNotifier.h ('k') | third_party/WebKit/Source/core/page/PageLifecycleObserver.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All Rights Reserved.	2 * Copyright (C) 2013 Google Inc. All Rights Reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 19 matching lines...) Expand all Loading...
30	30

31 namespace blink {	31 namespace blink {

32	32

33 void PageLifecycleNotifier::notifyPageVisibilityChanged()	33 void PageLifecycleNotifier::notifyPageVisibilityChanged()

34 {	34 {

35 TemporaryChange<IterationState> scope(m_iterationState, AllowingNone);	35 TemporaryChange<IterationState> scope(m_iterationState, AllowingNone);

36 for (PageLifecycleObserver* observer : m_observers)	36 for (PageLifecycleObserver* observer : m_observers)

37 observer->pageVisibilityChanged();	37 observer->pageVisibilityChanged();

38 }	38 }

39	39

40 void PageLifecycleNotifier::notifyDidCommitLoad(LocalFrame* frame)

41 {

42 TemporaryChange<IterationState> scope(m_iterationState, AllowingNone);

43 for (PageLifecycleObserver* observer : m_observers)

44 observer->didCommitLoad(frame);

45 }

46

47 } // namespace blink	40 } // namespace blink

OLD	NEW