Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2134013002: media: VEA unittest: make sure allocated memory is 64byte aligned (Closed)

Created:
4 years, 5 months ago by wuchengli
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

media: VEA unittest: make sure allocated memory is 64byte aligned When running video_encode_accelerator_unittest : ../../media/gpu/video_encode_accelerator_unittest.cc:301: Failure Value of: 0 Expected: reinterpret_cast<off_t>(&test_stream->aligned_in_file_data[0]) & 63 Which is: 32 File should be mapped at a 64 byte boundary Also reuse base::bits::Align. BUG=624254 TEST=video_encode_accelerator_unittest Review-Url: https://codereview.chromium.org/2110063002 Cr-Commit-Position: refs/heads/master@{#403435} (cherry picked from commit b79f630424367d6d65de0e7e0a8e80a823e79952) Committed: https://chromium.googlesource.com/chromium/src/+/341905a75a513580e7c1ceaa9b10ac0cbc90d08a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M media/gpu/video_encode_accelerator_unittest.cc View 4 chunks +35 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wuchengli
4 years, 5 months ago (2016-07-11 03:15:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
341905a75a513580e7c1ceaa9b10ac0cbc90d08a.

Powered by Google App Engine
This is Rietveld 408576698