media: VEA unittest: make sure allocated memory is 64byte aligned

media: VEA unittest: make sure allocated memory is 64byte aligned

When running video_encode_accelerator_unittest :

../../media/gpu/video_encode_accelerator_unittest.cc:301: Failure
Value of: 0
Expected: reinterpret_cast<off_t>(&test_stream->aligned_in_file_data[0]) & 63
Which is: 32
File should be mapped at a 64 byte boundary

Also reuse base::bits::Align.

BUG=624254
TEST=video_encode_accelerator_unittest

Committed: https://crrev.com/b79f630424367d6d65de0e7e0a8e80a823e79952
Cr-Commit-Position: refs/heads/master@{#403435}

[llandwerlin-old, 2016-06-29 12:47:29]

lionel.g.landwerlin@intel.com changed reviewers:
+ wuchengli@chromium.org

[llandwerlin-old, 2016-06-29 12:47:30]

wuchengli@: PTAL, Thanks

[wuchengli, 2016-06-29 14:39:30]

wuchengli@chromium.org changed reviewers:
+ henryhsu@chromium.org, posciak@chromium.org

[wuchengli, 2016-06-29 14:39:31]

+Henry.

Today Henry uploaded a patch to fix this.
https://codereview.chromium.org/2108053003. I did a quick look on both patches.
It looks like this patch is cleaner. We'll discuss tomorrow and choose one to
proceed.

[llandwerlin-old, 2016-06-29 14:42:42]

Description was changed from

==========
media: VEA unittest: make sure allocated memory is 64byte aligned

When running video_encode_accelerator_unittest :

../../media/gpu/video_encode_accelerator_unittest.cc:301: Failure
Value of: 0
Expected: reinterpret_cast<off_t>(&test_stream->aligned_in_file_data[0]) & 63
Which is: 32
File should be mapped at a 64 byte boundary

Also reuse base::bits::Align.

BUG=None
TEST=video_encode_accelerator_unittest
==========

to

==========
media: VEA unittest: make sure allocated memory is 64byte aligned

When running video_encode_accelerator_unittest :

../../media/gpu/video_encode_accelerator_unittest.cc:301: Failure
Value of: 0
Expected: reinterpret_cast<off_t>(&test_stream->aligned_in_file_data[0]) & 63
Which is: 32
File should be mapped at a 64 byte boundary

Also reuse base::bits::Align.

BUG=624254
TEST=video_encode_accelerator_unittest
==========

[wuchengli, 2016-06-30 14:02:37]

wuchengli@chromium.org changed reviewers:
- henryhsu@chromium.org, posciak@chromium.org

[wuchengli, 2016-06-30 14:02:37]

We'll go with your patch and abandon http://crrev.com/2108053003. I didn't get
to review this today. I'll review it tomorrow.

[wuchengli, 2016-07-01 06:25:31]

LGTM

https://codereview.chromium.org/2110063002/diff/1/media/gpu/video_encode_acce...
File media/gpu/video_encode_accelerator_unittest.cc (right):

https://codereview.chromium.org/2110063002/diff/1/media/gpu/video_encode_acce...
media/gpu/video_encode_accelerator_unittest.cc:20: #include
"base/files/memory_mapped_file.h"
This can be removed.

https://codereview.chromium.org/2110063002/diff/1/media/gpu/video_encode_acce...
media/gpu/video_encode_accelerator_unittest.cc:166: AlignedAllocator(const
AlignedAllocator<T1, ByteAlignment>&) {}
add explict?

[llandwerlin-old, 2016-07-01 08:11:39]

Thanks!

https://codereview.chromium.org/2110063002/diff/1/media/gpu/video_encode_acce...
File media/gpu/video_encode_accelerator_unittest.cc (right):

https://codereview.chromium.org/2110063002/diff/1/media/gpu/video_encode_acce...
media/gpu/video_encode_accelerator_unittest.cc:20: #include
"base/files/memory_mapped_file.h"
On 2016/07/01 06:25:30, wuchengli wrote:
> This can be removed.

Done.

https://codereview.chromium.org/2110063002/diff/1/media/gpu/video_encode_acce...
media/gpu/video_encode_accelerator_unittest.cc:166: AlignedAllocator(const
AlignedAllocator<T1, ByteAlignment>&) {}
On 2016/07/01 06:25:30, wuchengli wrote:
> add explict?

Done.

[wuchengli, 2016-07-01 08:18:05]

lgtm

[wuchengli, 2016-07-01 08:23:04]

The CQ bit was checked by wuchengli@chromium.org

[commit-bot: I haz the power, 2016-07-01 08:23:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 10:49:27]

Description was changed from

==========
media: VEA unittest: make sure allocated memory is 64byte aligned

When running video_encode_accelerator_unittest :

../../media/gpu/video_encode_accelerator_unittest.cc:301: Failure
Value of: 0
Expected: reinterpret_cast<off_t>(&test_stream->aligned_in_file_data[0]) & 63
Which is: 32
File should be mapped at a 64 byte boundary

Also reuse base::bits::Align.

BUG=624254
TEST=video_encode_accelerator_unittest
==========

to

==========
media: VEA unittest: make sure allocated memory is 64byte aligned

When running video_encode_accelerator_unittest :

../../media/gpu/video_encode_accelerator_unittest.cc:301: Failure
Value of: 0
Expected: reinterpret_cast<off_t>(&test_stream->aligned_in_file_data[0]) & 63
Which is: 32
File should be mapped at a 64 byte boundary

Also reuse base::bits::Align.

BUG=624254
TEST=video_encode_accelerator_unittest
==========

[commit-bot: I haz the power, 2016-07-01 10:49:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-01 10:51:12]

Description was changed from

==========
media: VEA unittest: make sure allocated memory is 64byte aligned

When running video_encode_accelerator_unittest :

../../media/gpu/video_encode_accelerator_unittest.cc:301: Failure
Value of: 0
Expected: reinterpret_cast<off_t>(&test_stream->aligned_in_file_data[0]) & 63
Which is: 32
File should be mapped at a 64 byte boundary

Also reuse base::bits::Align.

BUG=624254
TEST=video_encode_accelerator_unittest
==========

to

==========
media: VEA unittest: make sure allocated memory is 64byte aligned

When running video_encode_accelerator_unittest :

../../media/gpu/video_encode_accelerator_unittest.cc:301: Failure
Value of: 0
Expected: reinterpret_cast<off_t>(&test_stream->aligned_in_file_data[0]) & 63
Which is: 32
File should be mapped at a 64 byte boundary

Also reuse base::bits::Align.

BUG=624254
TEST=video_encode_accelerator_unittest

Committed: https://crrev.com/b79f630424367d6d65de0e7e0a8e80a823e79952
Cr-Commit-Position: refs/heads/master@{#403435}
==========

[commit-bot: I haz the power, 2016-07-01 10:51:13]

Patchset 3 (id:??) landed as
https://crrev.com/b79f630424367d6d65de0e7e0a8e80a823e79952
Cr-Commit-Position: refs/heads/master@{#403435}