Remove SVGZoomEvent interface and onzoom attribute

Remove SVGZoomEvent interface and onzoom attribute

Remove SVGZoomEvent(s) interface and its corresponding
onzoom attribute.

It has been removed from SVG 2.0 specification.

BUG=367890
Committed: https://crrev.com/3456eac8244e0afc9f0f1e276a0625c7fec10dd6
Cr-Commit-Position: refs/heads/master@{#405061}

[Shanmuga Pandi, 2016-07-11 09:34:23]

shanmuga.m@samsung.com changed reviewers:
+ rob.buis@samsung.com

[Shanmuga Pandi, 2016-07-11 09:34:24]

PTAL!!

[rwlbuis, 2016-07-11 18:44:24]

On 2016/07/11 09:34:24, Shanmuga Pandi wrote:
> PTAL!!

I think you also need to remove the SVGZoomEvent.idl :)

[Shanmuga Pandi, 2016-07-12 08:59:15]

On 2016/07/11 18:44:24, rwlbuis wrote:
> On 2016/07/11 09:34:24, Shanmuga Pandi wrote:
> > PTAL!!
> 
> I think you also need to remove the SVGZoomEvent.idl :)

OOPS.. Done now :)

[Shanmuga Pandi, 2016-07-12 09:13:45]

Description was changed from

==========
Deprecate SVGZoomEvent interface and onzoom attribute

Deprecate SVGZoomEvent(s) interface and its corresponding
onzoom attribute.

It has been removed from SVG 2.0 specification.

BUG=367890
==========

to

==========
Deprecate SVGZoomEvent interface and onzoom attribute

Deprecate SVGZoomEvent(s) interface and its corresponding
onzoom attribute.

It has been removed from SVG 2.0 specification.

BUG=367890
==========

[Shanmuga Pandi, 2016-07-12 09:13:46]

shanmuga.m@samsung.com changed reviewers:
+ davve@opera.com, foolip@chromium.org, fs@opera.com, pdr@chromium.org

[Shanmuga Pandi, 2016-07-12 09:14:18]

shanmuga.m@samsung.com changed reviewers:
+ timvolodine@chromium.org

[Shanmuga Pandi, 2016-07-12 09:14:19]

PTAL!!

[foolip, 2016-07-12 09:35:06]

This will need an Intent to Remove on blink-dev, you can find the template in
http://www.chromium.org/blink#TOC-Launch-Process:-Deprecation

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent-expected.txt
(right):

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent-expected.txt:166:
FAIL SVGZoomEvent should be an alias for SVGZoomEvent. Failed to execute
'createEvent' on 'Document': The provided event type ('SVGZoomEvent') is
invalid.
https://github.com/w3c/web-platform-tests needs to be updated to instead test
that SVGZoomEvent is not supported. Is that something you'd be interested in
taking care of?

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/custom/global-constructors-expected.txt
(right):

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/custom/global-constructors-expected.txt:105:
FAIL SVGZoomEvent.toString() should be function SVGZoomEvent() { [native code]
}. Threw exception ReferenceError: SVGZoomEvent is not defined
Edit LayoutTests/svg/custom/script-tests/global-constructors.js instead

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/svg2-inheritance-expected.txt
(right):

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/svg2-inheritance-expected.txt:87: FAIL
SVGZoomEvent is not defined
Here too, edit the test instead.

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_event_factory.py (right):

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_event_factory.py:71: def
create_event_deprecate_list(name):
Remove this and deprecate_name where it is used.

[davve, 2016-07-12 09:36:38]

Looks right on track. But what about an Intent to remove on blink-dev with link
attached to description?

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_event_factory.py (left):

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_event_factory.py:71: def
create_event_deprecate_list(name):
I suggest removing the create_event_deprecate_list functionality entirely since
it's now empty.

You need to modify
third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl too by
removing the relevant lines.

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_event_factory.py:80: def
deprecate_name(name):
And this too, of course.

[Shanmuga Pandi, 2016-07-12 13:06:11]

PTAL

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent-expected.txt
(right):

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent-expected.txt:166:
FAIL SVGZoomEvent should be an alias for SVGZoomEvent. Failed to execute
'createEvent' on 'Document': The provided event type ('SVGZoomEvent') is
invalid.
On 2016/07/12 09:35:06, Philip Jägenstedt wrote:
> https://github.com/w3c/web-platform-tests needs to be updated to instead test
> that SVGZoomEvent is not supported. Is that something you'd be interested in
> taking care of?

Raised bug on that.
https://github.com/w3c/web-platform-tests/issues/3292

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/custom/global-constructors-expected.txt
(right):

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/custom/global-constructors-expected.txt:105:
FAIL SVGZoomEvent.toString() should be function SVGZoomEvent() { [native code]
}. Threw exception ReferenceError: SVGZoomEvent is not defined
On 2016/07/12 09:35:06, Philip Jägenstedt wrote:
> Edit LayoutTests/svg/custom/script-tests/global-constructors.js instead

Done.

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/svg2-inheritance-expected.txt
(right):

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/svg2-inheritance-expected.txt:87: FAIL
SVGZoomEvent is not defined
On 2016/07/12 09:35:06, Philip Jägenstedt wrote:
> Here too, edit the test instead.

Done.

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_event_factory.py (left):

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_event_factory.py:71: def
create_event_deprecate_list(name):
On 2016/07/12 09:36:38, David Vest wrote:
> I suggest removing the create_event_deprecate_list functionality entirely
since
> it's now empty.
> 
> You need to modify
> third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl too by
> removing the relevant lines.

Done.

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_event_factory.py:80: def
deprecate_name(name):
On 2016/07/12 09:36:38, David Vest wrote:
> And this too, of course.

Done.

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_event_factory.py (right):

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_event_factory.py:71: def
create_event_deprecate_list(name):
On 2016/07/12 09:35:06, Philip Jägenstedt wrote:
> Remove this and deprecate_name where it is used.

Done.

[foolip, 2016-07-12 13:12:10]

lgtm % wpt failures. If you really don't want to deal with that it's OK, it's up
to you.

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent-expected.txt
(right):

https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent-expected.txt:166:
FAIL SVGZoomEvent should be an alias for SVGZoomEvent. Failed to execute
'createEvent' on 'Document': The provided event type ('SVGZoomEvent') is
invalid.
On 2016/07/12 13:06:10, Shanmuga Pandi wrote:
> On 2016/07/12 09:35:06, Philip Jägenstedt wrote:
> > https://github.com/w3c/web-platform-tests needs to be updated to instead
test
> > that SVGZoomEvent is not supported. Is that something you'd be interested in
> > taking care of?
> 
> Raised bug on that.
> https://github.com/w3c/web-platform-tests/issues/3292

Do you also plan to work on those tests? Failures in imported/wpt/ need a
tracking bug, so I'm thinking it might be less overall work to first change the
tests. I can review and merge in wpt for you.

[foolip, 2016-07-12 13:12:46]

Oh, and can you update the CL description to say Remove instead of Deprecate,
and link to the blink-dev thread?

[Shanmuga Pandi, 2016-07-12 13:13:59]

Description was changed from

==========
Deprecate SVGZoomEvent interface and onzoom attribute

Deprecate SVGZoomEvent(s) interface and its corresponding
onzoom attribute.

It has been removed from SVG 2.0 specification.

BUG=367890
==========

to

==========
Remove SVGZoomEvent interface and onzoom attribute

Remove SVGZoomEvent(s) interface and its corresponding
onzoom attribute.

It has been removed from SVG 2.0 specification.

BUG=367890
==========

[Shanmuga Pandi, 2016-07-12 13:17:55]

On 2016/07/12 13:12:10, Philip Jägenstedt wrote:
> lgtm % wpt failures. If you really don't want to deal with that it's OK, it's
up
> to you.
> 
>
https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent-expected.txt
> (right):
> 
>
https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent-expected.txt:166:
> FAIL SVGZoomEvent should be an alias for SVGZoomEvent. Failed to execute
> 'createEvent' on 'Document': The provided event type ('SVGZoomEvent') is
> invalid.
> On 2016/07/12 13:06:10, Shanmuga Pandi wrote:
> > On 2016/07/12 09:35:06, Philip Jägenstedt wrote:
> > > https://github.com/w3c/web-platform-tests needs to be updated to instead
> test
> > > that SVGZoomEvent is not supported. Is that something you'd be interested
in
> > > taking care of?
> > 
> > Raised bug on that.
> > https://github.com/w3c/web-platform-tests/issues/3292
> 
> Do you also plan to work on those tests? Failures in imported/wpt/ need a
> tracking bug, so I'm thinking it might be less overall work to first change
the
> tests. I can review and merge in wpt for you.

Some thing I am not clear. 
Should I update the imported/wgt/ now?
I thought it should be updated on https://github.com/w3c/web-platform-tests
first, then update imported/wgt/ ?
Are you expecting me to change the code in github also ?

[Shanmuga Pandi, 2016-07-12 13:20:19]

On 2016/07/12 13:12:46, Philip Jägenstedt wrote:
> Oh, and can you update the CL description to say Remove instead of Deprecate,
> and link to the blink-dev thread?

Oh. Done!! :)
Thank you

[foolip, 2016-07-12 13:51:49]

On 2016/07/12 13:17:55, Shanmuga Pandi wrote:
> On 2016/07/12 13:12:10, Philip Jägenstedt wrote:
> > lgtm % wpt failures. If you really don't want to deal with that it's OK,
it's
> up
> > to you.
> > 
> >
>
https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
> > File
> >
>
third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent-expected.txt
> > (right):
> > 
> >
>
https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
> >
>
third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent-expected.txt:166:
> > FAIL SVGZoomEvent should be an alias for SVGZoomEvent. Failed to execute
> > 'createEvent' on 'Document': The provided event type ('SVGZoomEvent') is
> > invalid.
> > On 2016/07/12 13:06:10, Shanmuga Pandi wrote:
> > > On 2016/07/12 09:35:06, Philip Jägenstedt wrote:
> > > > https://github.com/w3c/web-platform-tests needs to be updated to instead
> > test
> > > > that SVGZoomEvent is not supported. Is that something you'd be
interested
> in
> > > > taking care of?
> > > 
> > > Raised bug on that.
> > > https://github.com/w3c/web-platform-tests/issues/3292
> > 
> > Do you also plan to work on those tests? Failures in imported/wpt/ need a
> > tracking bug, so I'm thinking it might be less overall work to first change
> the
> > tests. I can review and merge in wpt for you.
> 
> Some thing I am not clear. 
> Should I update the imported/wgt/ now?
> I thought it should be updated on https://github.com/w3c/web-platform-tests
> first, then update imported/wgt/ ?
> Are you expecting me to change the code in github also ?

I'm not exactly expecting, I'm asking if you'd like to do it. The current
process is that one has to submit a PR to the GitHub repository, get review for
that and merge it. Then it comes back to us via an import script. It's not at
all streamlined and tkent@ is working on making that better, but one can do it.
The benefit of doing this is that other engines that import wpt (Gecko,
currently) will notice the failure and that might cause them to make the same
change faster.

[davve, 2016-07-12 14:00:09]

lgtm. Thanks!

[rwlbuis, 2016-07-12 14:24:39]

Peer looks good to me.

[timvolodine, 2016-07-12 16:08:30]

android_webview/.. -- lgtm

[Shanmuga Pandi, 2016-07-13 03:59:04]

On 2016/07/12 13:51:49, Philip Jägenstedt wrote:
> On 2016/07/12 13:17:55, Shanmuga Pandi wrote:
> > On 2016/07/12 13:12:10, Philip Jägenstedt wrote:
> > > lgtm % wpt failures. If you really don't want to deal with that it's OK,
> it's
> > up
> > > to you.
> > > 
> > >
> >
>
https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
> > > File
> > >
> >
>
third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent-expected.txt
> > > (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2133983003/diff/20001/third_party/WebKit/Layo...
> > >
> >
>
third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent-expected.txt:166:
> > > FAIL SVGZoomEvent should be an alias for SVGZoomEvent. Failed to execute
> > > 'createEvent' on 'Document': The provided event type ('SVGZoomEvent') is
> > > invalid.
> > > On 2016/07/12 13:06:10, Shanmuga Pandi wrote:
> > > > On 2016/07/12 09:35:06, Philip Jägenstedt wrote:
> > > > > https://github.com/w3c/web-platform-tests needs to be updated to
instead
> > > test
> > > > > that SVGZoomEvent is not supported. Is that something you'd be
> interested
> > in
> > > > > taking care of?
> > > > 
> > > > Raised bug on that.
> > > > https://github.com/w3c/web-platform-tests/issues/3292
> > > 
> > > Do you also plan to work on those tests? Failures in imported/wpt/ need a
> > > tracking bug, so I'm thinking it might be less overall work to first
change
> > the
> > > tests. I can review and merge in wpt for you.
> > 
> > Some thing I am not clear. 
> > Should I update the imported/wgt/ now?
> > I thought it should be updated on https://github.com/w3c/web-platform-tests
> > first, then update imported/wgt/ ?
> > Are you expecting me to change the code in github also ?
> 
> I'm not exactly expecting, I'm asking if you'd like to do it. The current
> process is that one has to submit a PR to the GitHub repository, get review
for
> that and merge it. Then it comes back to us via an import script. It's not at
> all streamlined and tkent@ is working on making that better, but one can do
it.
> The benefit of doing this is that other engines that import wpt (Gecko,
> currently) will notice the failure and that might cause them to make the same
> change faster.

I just asked :). BCZ havent done this process previously. 
I am checking the process internally.
Thank you

[Shanmuga Pandi, 2016-07-13 04:00:04]

The CQ bit was checked by shanmuga.m@samsung.com

[commit-bot: I haz the power, 2016-07-13 04:01:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 04:07:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 04:07:28]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Shanmuga Pandi, 2016-07-13 05:20:52]

The CQ bit was checked by shanmuga.m@samsung.com

[Shanmuga Pandi, 2016-07-13 05:20:53]

The patchset sent to the CQ was uploaded after l-g-t-m from davve@opera.com,
timvolodine@chromium.org, foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2133983003/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2016-07-13 05:21:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 07:05:24]

Description was changed from

==========
Remove SVGZoomEvent interface and onzoom attribute

Remove SVGZoomEvent(s) interface and its corresponding
onzoom attribute.

It has been removed from SVG 2.0 specification.

BUG=367890
==========

to

==========
Remove SVGZoomEvent interface and onzoom attribute

Remove SVGZoomEvent(s) interface and its corresponding
onzoom attribute.

It has been removed from SVG 2.0 specification.

BUG=367890
==========

[commit-bot: I haz the power, 2016-07-13 07:05:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-13 07:09:27]

Description was changed from

==========
Remove SVGZoomEvent interface and onzoom attribute

Remove SVGZoomEvent(s) interface and its corresponding
onzoom attribute.

It has been removed from SVG 2.0 specification.

BUG=367890
==========

to

==========
Remove SVGZoomEvent interface and onzoom attribute

Remove SVGZoomEvent(s) interface and its corresponding
onzoom attribute.

It has been removed from SVG 2.0 specification.

BUG=367890

Committed: https://crrev.com/3456eac8244e0afc9f0f1e276a0625c7fec10dd6
Cr-Commit-Position: refs/heads/master@{#405061}
==========

[commit-bot: I haz the power, 2016-07-13 07:09:29]

Patchset 4 (id:??) landed as
https://crrev.com/3456eac8244e0afc9f0f1e276a0625c7fec10dd6
Cr-Commit-Position: refs/heads/master@{#405061}

[foolip, 2016-07-13 08:45:24]

On 2016/07/12 13:12:46, Philip Jägenstedt wrote:
> Oh, and can you update the CL description to say Remove instead of Deprecate,
> and link to the blink-dev thread?

The thread is
https://groups.google.com/a/chromium.org/d/msg/blink-dev/wm0P8R-u4rg/ZRp_R0PE...
and I should have said you need to wait for 3 LGTMs before landing this CL. I'll
poke the thread so that this doesn't need to be reverted.

[davve, 2016-07-13 08:49:53]

On 2016/07/13 07:09:29, commit-bot: I haz the power wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/3456eac8244e0afc9f0f1e276a0625c7fec10dd6
> Cr-Commit-Position: refs/heads/master@{#405061}

I may be missing something here, but I don't see any blink-dev link in the
committed description (commit message) and as of writing only two LGTM's on the
blink-dev thread (from foolip and rbyers). What happened?

[Shanmuga Pandi, 2016-07-13 08:50:54]

On 2016/07/13 08:45:24, Philip Jägenstedt wrote:
> On 2016/07/12 13:12:46, Philip Jägenstedt wrote:
> > Oh, and can you update the CL description to say Remove instead of
Deprecate,
> > and link to the blink-dev thread?
> 
> The thread is
>
https://groups.google.com/a/chromium.org/d/msg/blink-dev/wm0P8R-u4rg/ZRp_R0PE...
> and I should have said you need to wait for 3 LGTMs before landing this CL.
I'll
> poke the thread so that this doesn't need to be reverted.

OOPS!! I should have waited it!!

[Shanmuga Pandi, 2016-07-13 08:54:07]

On 2016/07/13 08:49:53, David Vest wrote:
> On 2016/07/13 07:09:29, commit-bot: I haz the power wrote:
> > Patchset 4 (id:??) landed as
> > https://crrev.com/3456eac8244e0afc9f0f1e276a0625c7fec10dd6
> > Cr-Commit-Position: refs/heads/master@{#405061}
> 
> I may be missing something here, but I don't see any blink-dev link in the
> committed description (commit message) and as of writing only two LGTM's on
the
> blink-dev thread (from foolip and rbyers). What happened?

Shall I revert this and will wait for some time to get 3 LGTMs?

[foolip, 2016-07-13 09:11:11]

On 2016/07/13 08:54:07, Shanmuga Pandi wrote:
> On 2016/07/13 08:49:53, David Vest wrote:
> > On 2016/07/13 07:09:29, commit-bot: I haz the power wrote:
> > > Patchset 4 (id:??) landed as
> > > https://crrev.com/3456eac8244e0afc9f0f1e276a0625c7fec10dd6
> > > Cr-Commit-Position: refs/heads/master@{#405061}
> > 
> > I may be missing something here, but I don't see any blink-dev link in the
> > committed description (commit message) and as of writing only two LGTM's on
> the
> > blink-dev thread (from foolip and rbyers). What happened?
> 
> Shall I revert this and will wait for some time to get 3 LGTMs?

No, I don't think this should be uncontroversial, I suggest waiting for a day or
two and revert only if there's any trouble on the thread.

[foolip, 2016-07-13 09:11:49]

On 2016/07/13 09:11:11, Philip Jägenstedt wrote:
> On 2016/07/13 08:54:07, Shanmuga Pandi wrote:
> > On 2016/07/13 08:49:53, David Vest wrote:
> > > On 2016/07/13 07:09:29, commit-bot: I haz the power wrote:
> > > > Patchset 4 (id:??) landed as
> > > > https://crrev.com/3456eac8244e0afc9f0f1e276a0625c7fec10dd6
> > > > Cr-Commit-Position: refs/heads/master@{#405061}
> > > 
> > > I may be missing something here, but I don't see any blink-dev link in the
> > > committed description (commit message) and as of writing only two LGTM's
on
> > the
> > > blink-dev thread (from foolip and rbyers). What happened?
> > 
> > Shall I revert this and will wait for some time to get 3 LGTMs?
> 
> No, I don't think this should be uncontroversial,

Uh, I think it *should be* uncontroversial...

[foolip, 2016-07-13 09:23:56]

There, thread now resolved, thanks for fixing this Shanmuga! If you'd like to
clean up more things in SVG, I'm pretty sure davve@opera.com could suggest a
thing or two :)

[Shanmuga Pandi, 2016-07-13 10:10:54]

On 2016/07/13 09:23:56, foolip wrote:
> There, thread now resolved, thanks for fixing this Shanmuga! If you'd like to
> clean up more things in SVG, I'm pretty sure mailto:davve@opera.com could
suggest a
> thing or two :)

Thanks Philip!!!

I am really interested to work on it.
@davve,
 Please suggest some more!!!