PasswordForm -> FormDigest for GetLogins

chrome/browser/password_manager/native_backend_libsecret.cc

Index: chrome/browser/password_manager/native_backend_libsecret.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret.cc b/chrome/browser/password_manager/native_backend_libsecret.cc
index 90711f8be6311164ab85c0eb4be9a0d79ef4ffaf..20042f2364595b27f4b120c8b486960d329c124c 100644
--- a/chrome/browser/password_manager/native_backend_libsecret.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret.cc
@@ -27,6 +27,7 @@
 using autofill::PasswordForm;
 using base::UTF8ToUTF16;
 using base::UTF16ToUTF8;
+using password_manager::PasswordStore;
 
 namespace {
 const char kEmptyString[] = "";
@@ -298,7 +299,7 @@ bool NativeBackendLibsecret::DisableAutoSignInForOrigins(
 }
 
 bool NativeBackendLibsecret::GetLogins(
-    const PasswordForm& form,
+    const PasswordStore::FormDigest& form,
     ScopedVector<autofill::PasswordForm>* forms) {
   return GetLoginsList(&form, ALL_LOGINS, forms);
 }
@@ -328,7 +329,9 @@ bool NativeBackendLibsecret::AddUpdateLoginSearch(
     return false;
   }
 
-  *forms = ConvertFormList(found, &lookup_form);
+  PasswordStore::FormDigest form = {

[dvadym, 2016/07/20 13:43:02]

nit: Why don't to use constructor of FormDigest that takes PasswordForm?

[vabr (Chromium), 2016/07/20 14:13:06]

Done.

+      lookup_form.scheme, lookup_form.signon_realm, lookup_form.origin};
+  *forms = ConvertFormList(found, &form);
   return true;
 }
 
@@ -402,7 +405,7 @@ bool NativeBackendLibsecret::GetAllLogins(
 }
 
 bool NativeBackendLibsecret::GetLoginsList(
-    const PasswordForm* lookup_form,
+    const PasswordStore::FormDigest* lookup_form,
     GetLoginsListOptions options,
     ScopedVector<autofill::PasswordForm>* forms) {
   LibsecretAttributesBuilder attrs;
@@ -498,7 +501,7 @@ bool NativeBackendLibsecret::RemoveLoginsBetween(
 
 ScopedVector<autofill::PasswordForm> NativeBackendLibsecret::ConvertFormList(
     GList* found,
-    const PasswordForm* lookup_form) {
+    const PasswordStore::FormDigest* lookup_form) {
   ScopedVector<autofill::PasswordForm> forms;
   password_manager::PSLDomainMatchMetric psl_domain_match_metric =
       password_manager::PSL_DOMAIN_MATCH_NONE;