components/password_manager/core/browser/password_form_manager.cc - Issue 2133953002: PasswordForm -> FormDigest for GetLogins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 2133953002: PasswordForm -> FormDigest for GetLogins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid

Patch Set: Just rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_form_manager.cc

diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc

index c3f9e10d513dfbc60477d6d9960277a6f07843c6..c7767b5c16eb377677e34211d723e26fc5d11827 100644

--- a/components/password_manager/core/browser/password_form_manager.cc

+++ b/components/password_manager/core/browser/password_form_manager.cc

@@ -418,7 +418,9 @@ void PasswordFormManager::FetchDataFromPasswordStore() {

NOTREACHED();

return;

}

- password_store->GetLogins(observed_form_, this);

+ password_store->GetLogins({observed_form_.scheme, observed_form_.signon_realm,

+ observed_form_.origin},

+ this);

dvadym 2016/07/20 13:43:02 Nit:Why don't to use constructor of FormDigest tha

vabr (Chromium) 2016/07/20 14:13:06 Done.

// The statistics isn't needed on mobile, only on desktop. Let's save some

// processor cycles.