gpu::GPUInfo::GPUDevice struct traits

Added typemap for gpu.mojom.GpuInfo, gpu.mojom.GpuDevice and gpu.mojom.CollectInfoResult

BUG=622707
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6bc355f1871c4c85f56ae4a05370b6c44fcab1f5
Cr-Commit-Position: refs/heads/master@{#405266}

[Alex Z., 2016-07-08 18:09:08]

Description was changed from

==========
Added typemap for gpu.mojom.GpuInfo, gpu.mojom.GpuDevice and
gpu.mojom.CollectInfoResult

BUG=622707
==========

to

==========
Added typemap for gpu.mojom.GpuInfo, gpu.mojom.GpuDevice and
gpu.mojom.CollectInfoResult

BUG=622707
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Alex Z., 2016-07-08 18:44:43]

staraz@chromium.org changed reviewers:
+ fsamuel@chromium.org, sky@chromium.org

[Alex Z., 2016-07-08 18:44:43]

fsamuel@chromium.org: Please review changes in the mojom files. 

sky@chromium.org: Please review changes in 
services/ui/common/gpu_service.*
services/ui/gles2/gpu_impl.cc
services/ui/gpu/gpu_service_impl.cc
services/ui/public/cpp/lib/gles2_context.cc
services/ui/ws/platform_display.cc

This CL is a skim-downed version of CL 2113543003. Please disregard the review
request for sent out earlier today.

[Alex Z., 2016-07-08 18:45:34]

staraz@chromium.org changed reviewers:
+ dcheng@chromium.org

[Alex Z., 2016-07-08 18:45:34]

dcheng@chromium.org: Please do a security review on the changed ipc files.

[Fady Samuel, 2016-07-08 18:47:56]

https://codereview.chromium.org/2133833002/diff/20001/gpu/ipc/common/gpu_info...
File gpu/ipc/common/gpu_info.mojom (right):

https://codereview.chromium.org/2133833002/diff/20001/gpu/ipc/common/gpu_info...
gpu/ipc/common/gpu_info.mojom:9: struct GpuDevice {};
Let's not land incomplete things here. Please remove this or implement this.

https://codereview.chromium.org/2133833002/diff/20001/gpu/ipc/common/gpu_info...
gpu/ipc/common/gpu_info.mojom:18: struct GpuInfo {};
Let's not land incomplete things here. Please remove this or implement this.

[Alex Z., 2016-07-11 15:18:10]

Description was changed from

==========
Added typemap for gpu.mojom.GpuInfo, gpu.mojom.GpuDevice and
gpu.mojom.CollectInfoResult

BUG=622707
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Added typemap for gpu.mojom.GpuInfo, gpu.mojom.GpuDevice and
gpu.mojom.CollectInfoResult

BUG=622707
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-07-12 01:27:30]

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/gpu_inf...
File gpu/ipc/common/gpu_info.mojom (right):

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/gpu_inf...
gpu/ipc/common/gpu_info.mojom:7: import "mojo/common/common_custom_types.mojom";
nit: Unnecessary include

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/gpu_inf...
gpu/ipc/common/gpu_info.mojom:9: struct GpuDevice {
nit: Add comment about where the C++ type is defined.

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/gpu_inf...
gpu/ipc/common/gpu_info.mojom:10: uint32 vendor_id;
nit: spacing.

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/gpu_inf...
File gpu/ipc/common/gpu_info_struct_traits.cc (right):

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/gpu_inf...
gpu/ipc/common/gpu_info_struct_traits.cc:10: bool
StructTraits<gpu::mojom::GpuDevice, gpu::GPUInfo::GPUDevice>::Read(
Match order in header file.

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/gpu_inf...
gpu/ipc/common/gpu_info_struct_traits.cc:16:
data.ReadVendorString(&out->vendor_string);
return data.ReadVectorString(&out->vendor_string) &&
  data.ReadDeviceString(&out->device_string);

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/struct_...
File gpu/ipc/common/struct_traits_unittest.cc (right):

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/struct_...
gpu/ipc/common/struct_traits_unittest.cc:67: EXPECT_FALSE(input.active);
Just explicitly set this.

[Alex Z., 2016-07-12 13:58:15]

https://codereview.chromium.org/2133833002/diff/20001/gpu/ipc/common/gpu_info...
File gpu/ipc/common/gpu_info.mojom (right):

https://codereview.chromium.org/2133833002/diff/20001/gpu/ipc/common/gpu_info...
gpu/ipc/common/gpu_info.mojom:9: struct GpuDevice {};
On 2016/07/08 18:47:56, Fady Samuel wrote:
> Let's not land incomplete things here. Please remove this or implement this.

Acknowledged.

https://codereview.chromium.org/2133833002/diff/20001/gpu/ipc/common/gpu_info...
gpu/ipc/common/gpu_info.mojom:18: struct GpuInfo {};
On 2016/07/08 18:47:56, Fady Samuel wrote:
> Let's not land incomplete things here. Please remove this or implement this.

Acknowledged.

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/gpu_inf...
File gpu/ipc/common/gpu_info.mojom (right):

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/gpu_inf...
gpu/ipc/common/gpu_info.mojom:7: import "mojo/common/common_custom_types.mojom";
On 2016/07/12 01:27:30, Fady Samuel wrote:
> nit: Unnecessary include

Done.

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/gpu_inf...
gpu/ipc/common/gpu_info.mojom:9: struct GpuDevice {
On 2016/07/12 01:27:30, Fady Samuel wrote:
> nit: Add comment about where the C++ type is defined.

Done.

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/gpu_inf...
gpu/ipc/common/gpu_info.mojom:10: uint32 vendor_id;
On 2016/07/12 01:27:29, Fady Samuel wrote:
> nit: spacing.

Done.

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/gpu_inf...
File gpu/ipc/common/gpu_info_struct_traits.cc (right):

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/gpu_inf...
gpu/ipc/common/gpu_info_struct_traits.cc:10: bool
StructTraits<gpu::mojom::GpuDevice, gpu::GPUInfo::GPUDevice>::Read(
On 2016/07/12 01:27:30, Fady Samuel wrote:
> Match order in header file.

This matches the the order in the header file (StructTraits<GPUDevice>::Read()
then EnumTraits<CollectInfoResult>::ToMojom() then FromMojom().

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/gpu_inf...
gpu/ipc/common/gpu_info_struct_traits.cc:16:
data.ReadVendorString(&out->vendor_string);
On 2016/07/12 01:27:30, Fady Samuel wrote:
> return data.ReadVectorString(&out->vendor_string) &&
>   data.ReadDeviceString(&out->device_string);

Done.

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/struct_...
File gpu/ipc/common/struct_traits_unittest.cc (right):

https://codereview.chromium.org/2133833002/diff/360001/gpu/ipc/common/struct_...
gpu/ipc/common/struct_traits_unittest.cc:67: EXPECT_FALSE(input.active);
On 2016/07/12 01:27:30, Fady Samuel wrote:
> Just explicitly set this.

Done.

[Fady Samuel, 2016-07-12 14:09:59]

lgtm

[Alex Z., 2016-07-12 14:28:28]

The CQ bit was checked by staraz@chromium.org

[commit-bot: I haz the power, 2016-07-12 14:29:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 14:38:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 14:38:50]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alex Z., 2016-07-12 14:45:49]

staraz@chromium.org changed reviewers:
+ msw@chromium.org
- sky@chromium.org

[dcheng, 2016-07-13 14:36:26]

mojom lgtm with nits addressed

https://codereview.chromium.org/2133833002/diff/380001/gpu/ipc/common/gpu_inf...
File gpu/ipc/common/gpu_info_struct_traits.cc (right):

https://codereview.chromium.org/2133833002/diff/380001/gpu/ipc/common/gpu_inf...
gpu/ipc/common/gpu_info_struct_traits.cc:55: return false;
Nit: NOREACHED() this (as well as line 34)

https://codereview.chromium.org/2133833002/diff/380001/gpu/ipc/common/gpu_inf...
File gpu/ipc/common/gpu_info_struct_traits.h (right):

https://codereview.chromium.org/2133833002/diff/380001/gpu/ipc/common/gpu_inf...
gpu/ipc/common/gpu_info_struct_traits.h:30: static std::string
vendor_string(const gpu::GPUInfo::GPUDevice& input) {
const std::string& to avoid the copy, here and below

[Alex Z., 2016-07-13 17:03:34]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 17:04:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 18:18:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 18:18:48]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Alex Z., 2016-07-13 18:23:02]

The CQ bit was checked by staraz@chromium.org

[Alex Z., 2016-07-13 18:23:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2133833002/#ps400001
(title: "Change according to comments")

[commit-bot: I haz the power, 2016-07-13 18:23:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 19:33:34]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names without "master." prefix is deprecated:
tryserver.chromium.linux, tryserver.chromium.mac, tryserver.chromium.win. For
more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-13 20:18:30]

Description was changed from

==========
Added typemap for gpu.mojom.GpuInfo, gpu.mojom.GpuDevice and
gpu.mojom.CollectInfoResult

BUG=622707
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Added typemap for gpu.mojom.GpuInfo, gpu.mojom.GpuDevice and
gpu.mojom.CollectInfoResult

BUG=622707
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-07-13 20:18:32]

Committed patchset #21 (id:400001)

[commit-bot: I haz the power, 2016-07-13 20:19:04]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 20:22:08]

Description was changed from

==========
Added typemap for gpu.mojom.GpuInfo, gpu.mojom.GpuDevice and
gpu.mojom.CollectInfoResult

BUG=622707
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Added typemap for gpu.mojom.GpuInfo, gpu.mojom.GpuDevice and
gpu.mojom.CollectInfoResult

BUG=622707
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6bc355f1871c4c85f56ae4a05370b6c44fcab1f5
Cr-Commit-Position: refs/heads/master@{#405266}
==========

[commit-bot: I haz the power, 2016-07-13 20:22:10]

Patchset 21 (id:??) landed as
https://crrev.com/6bc355f1871c4c85f56ae4a05370b6c44fcab1f5
Cr-Commit-Position: refs/heads/master@{#405266}