gpu/ipc/common/gpu_info.mojom - Issue 2133833002: gpu::GPUInfo::GPUDevice struct traits

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gpu/ipc/common/gpu_info.mojom

Issue 2133833002: gpu::GPUInfo::GPUDevice struct traits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed unnecessary changes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module gpu.mojom;

	6

	7 import "mojo/common/common_custom_types.mojom";
	Fady Samuel 2016/07/12 01:27:30 nit: Unnecessary include nit: Unnecessary include Alex Z. 2016/07/12 13:58:15 Done. Show quoted text On 2016/07/12 01:27:30, Fady Samuel wrote: > nit: Unnecessary include Done.
	8

	9 struct GpuDevice {
	Fady Samuel 2016/07/12 01:27:30 nit: Add comment about where the C++ type is defin nit: Add comment about where the C++ type is defined. Alex Z. 2016/07/12 13:58:15 Done. Show quoted text On 2016/07/12 01:27:30, Fady Samuel wrote: > nit: Add comment about where the C++ type is defined. Done.
	10 uint32 vendor_id;
	Fady Samuel 2016/07/12 01:27:29 nit: spacing. nit: spacing. Alex Z. 2016/07/12 13:58:15 Done. Show quoted text On 2016/07/12 01:27:29, Fady Samuel wrote: > nit: spacing. Done.
	11 uint32 device_id;

	12 bool active;

	13 string vendor_string;

	14 string device_string;

	15 };

	16

	17 enum CollectInfoResult {

	18 kCollectInfoNone = 0,

	19 kCollectInfoSuccess = 1,

	20 kCollectInfoNonFatalFailure = 2,

	21 kCollectInfoFatalFailure = 3

	22 };

OLD	NEW