Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5144)

Unified Diff: chrome/common/extensions/api/common_extension_api_unittest.cc

Issue 2133783002: [Extensions] Break up BaseFeatureProvider, create JSONFeatureProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/chrome_extensions_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/common_extension_api_unittest.cc
diff --git a/chrome/common/extensions/api/common_extension_api_unittest.cc b/chrome/common/extensions/api/common_extension_api_unittest.cc
index d24fd46b65fe1cd91f2cc0e1c29dae2a23dacdee..edcb0b37c76c747d645bbf6873ad59e00e246da1 100644
--- a/chrome/common/extensions/api/common_extension_api_unittest.cc
+++ b/chrome/common/extensions/api/common_extension_api_unittest.cc
@@ -24,7 +24,7 @@
#include "extensions/common/extension.h"
#include "extensions/common/extension_builder.h"
#include "extensions/common/features/api_feature.h"
-#include "extensions/common/features/base_feature_provider.h"
+#include "extensions/common/features/json_feature_provider.h"
#include "extensions/common/features/simple_feature.h"
#include "extensions/common/manifest.h"
#include "extensions/common/manifest_constants.h"
@@ -177,7 +177,7 @@ TEST(ExtensionAPITest, APIFeatures) {
std::unique_ptr<base::DictionaryValue> value(
static_cast<base::DictionaryValue*>(
base::JSONReader::Read(api_features_str).release()));
- BaseFeatureProvider api_feature_provider(*value, CreateAPIFeature);
+ JSONFeatureProvider api_feature_provider(*value, CreateAPIFeature);
for (size_t i = 0; i < arraysize(test_data); ++i) {
ExtensionAPI api;
@@ -271,7 +271,7 @@ TEST(ExtensionAPITest, IsAnyFeatureAvailableToContext) {
std::unique_ptr<base::DictionaryValue> value(
static_cast<base::DictionaryValue*>(
base::JSONReader::Read(api_features_str).release()));
- BaseFeatureProvider api_feature_provider(*value, CreateAPIFeature);
+ JSONFeatureProvider api_feature_provider(*value, CreateAPIFeature);
for (size_t i = 0; i < arraysize(test_data); ++i) {
ExtensionAPI api;
@@ -701,7 +701,7 @@ TEST(ExtensionAPITest, FeaturesRequireContexts) {
};
for (size_t i = 0; i < arraysize(test_data); ++i) {
- BaseFeatureProvider api_feature_provider(*test_data[i].api_features,
+ JSONFeatureProvider api_feature_provider(*test_data[i].api_features,
CreateAPIFeature);
Feature* feature = api_feature_provider.GetFeature("test");
EXPECT_EQ(test_data[i].expect_success, feature != NULL) << i;
« no previous file with comments | « no previous file | chrome/common/extensions/chrome_extensions_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698