Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2133743002: Removes crash keys for crbug.com/621730 (Closed)

Created:
4 years, 5 months ago by Yuki
Modified:
4 years, 5 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes crash keys for crbug.com/621730 Removes crash keys and temporary instrumentations to investigate the issue crbug.com/621730 . The crash keys and instrumentations were introduced at https://crrev.com/2107773002 https://crrev.com/2101283002 BUG=621730 Committed: https://crrev.com/689a82c8d0ca7cc00eb59778ff4fb5e9f1b2c4de Cr-Commit-Position: refs/heads/master@{#404599}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Synced. #

Patch Set 3 : Addressed review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M blimp/engine/app/blimp_engine_crash_keys.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp View 1 2 2 chunks +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 2 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yuki
Could you guys review this CL?
4 years, 5 months ago (2016-07-08 14:39:16 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/2133743002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp File third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp (right): https://codereview.chromium.org/2133743002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp#newcode38 third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp:38: #include "wtf/debug/CrashLogging.h" Remove. https://codereview.chromium.org/2133743002/diff/1/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (right): https://codereview.chromium.org/2133743002/diff/1/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp#newcode82 ...
4 years, 5 months ago (2016-07-08 15:01:02 UTC) #3
haraken
LGTM
4 years, 5 months ago (2016-07-08 15:10:03 UTC) #4
ncarter (slow)
lgtm
4 years, 5 months ago (2016-07-08 16:37:16 UTC) #5
Yuki
https://codereview.chromium.org/2133743002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp File third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp (right): https://codereview.chromium.org/2133743002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp#newcode38 third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp:38: #include "wtf/debug/CrashLogging.h" On 2016/07/08 15:01:02, Robert Sesek wrote: > ...
4 years, 5 months ago (2016-07-11 04:00:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133743002/40001
4 years, 5 months ago (2016-07-11 04:01:05 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-11 05:34:02 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 05:37:43 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/689a82c8d0ca7cc00eb59778ff4fb5e9f1b2c4de
Cr-Commit-Position: refs/heads/master@{#404599}

Powered by Google App Engine
This is Rietveld 408576698