Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

Issue 2133743002: Removes crash keys for crbug.com/621730 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp
index b35c509c2cf782742d1d87ea594300cda8014b7c..f9b9861c1b911990087ab6596f68a75d6e184585 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp
@@ -35,7 +35,6 @@
#include "core/dom/Document.h"
#include "core/events/Event.h"
#include "core/frame/LocalFrame.h"
-#include "wtf/debug/CrashLogging.h"
namespace blink {
@@ -92,28 +91,6 @@ v8::Local<v8::Value> V8EventListener::callListenerFunction(ScriptState* scriptSt
if (scriptState->world().isMainWorld() && !frame->script().canExecuteScripts(AboutToExecuteScript))
return v8::Local<v8::Value>();
- // Temporary instrumentation for http://crbug.com/621730.
- String scriptInfo;
- if (event->type() == EventTypeNames::message) {
- v8::HandleScope handleScope(isolate());
- StringBuilder scriptInfoBuilder;
- V8StringResource<> functionName = handlerFunction->GetDebugName();
- if (functionName.prepare()) {
- scriptInfoBuilder.append(static_cast<String>(functionName));
- }
- scriptInfoBuilder.append(':');
- scriptInfoBuilder.appendNumber(handlerFunction->GetScriptLineNumber());
- scriptInfoBuilder.append(':');
- scriptInfoBuilder.appendNumber(handlerFunction->GetScriptColumnNumber());
- scriptInfoBuilder.append(':');
- V8StringResource<> scriptName = handlerFunction->GetScriptOrigin().ResourceName();
- if (scriptName.prepare()) {
- scriptInfoBuilder.append(static_cast<String>(scriptName));
- }
- scriptInfo = scriptInfoBuilder.toString();
- }
- WTF::debug::ScopedCrashKey("postmessage_script_info", scriptInfo.utf8().data());
-
v8::Local<v8::Value> parameters[1] = { jsEvent };
v8::Local<v8::Value> result;
if (!V8ScriptRunner::callFunction(handlerFunction, frame->document(), receiver, WTF_ARRAY_LENGTH(parameters), parameters, scriptState->isolate()).ToLocal(&result))
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698