Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Issue 2133693002: Remove class blink::WebURLResponsePrivate (Closed)

Created:
4 years, 5 months ago by Adam Rice
Modified:
4 years, 5 months ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove class blink::WebURLResponsePrivate WebURLResponse can directly point to a ResourceResponse object instead. BUG=625529 Committed: https://crrev.com/8036fd1c9bbd45f18ab78716e641c6d6cf974f79 Cr-Commit-Position: refs/heads/master@{#404611}

Patch Set 1 #

Patch Set 2 : Remove WebURLResponsePrivate.h from gypi file #

Total comments: 2

Patch Set 3 : Restrict the unowned constructor to WebURLResponse #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -176 lines) Patch
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLResponse.cpp View 8 chunks +93 lines, -104 lines 0 comments Download
D third_party/WebKit/Source/platform/exported/WebURLResponsePrivate.h View 1 chunk +0 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WrappedResourceResponse.h View 1 chunk +4 lines, -10 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLResponse.h View 1 2 2 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Adam Rice
I'm not sure that this is better, but it is shorter. PTAL.
4 years, 5 months ago (2016-07-11 02:29:26 UTC) #2
kinuko
Looks fine to me. lgtm https://codereview.chromium.org/2133693002/diff/20001/third_party/WebKit/public/platform/WebURLResponse.h File third_party/WebKit/public/platform/WebURLResponse.h (right): https://codereview.chromium.org/2133693002/diff/20001/third_party/WebKit/public/platform/WebURLResponse.h#newcode298 third_party/WebKit/public/platform/WebURLResponse.h:298: BLINK_PLATFORM_EXPORT explicit WebURLResponse(ResourceResponse*); Put ...
4 years, 5 months ago (2016-07-11 03:44:12 UTC) #3
Adam Rice
https://codereview.chromium.org/2133693002/diff/20001/third_party/WebKit/public/platform/WebURLResponse.h File third_party/WebKit/public/platform/WebURLResponse.h (right): https://codereview.chromium.org/2133693002/diff/20001/third_party/WebKit/public/platform/WebURLResponse.h#newcode298 third_party/WebKit/public/platform/WebURLResponse.h:298: BLINK_PLATFORM_EXPORT explicit WebURLResponse(ResourceResponse*); On 2016/07/11 03:44:12, kinuko wrote: > ...
4 years, 5 months ago (2016-07-11 05:44:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133693002/40001
4 years, 5 months ago (2016-07-11 07:31:05 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-11 07:34:48 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 07:36:31 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8036fd1c9bbd45f18ab78716e641c6d6cf974f79
Cr-Commit-Position: refs/heads/master@{#404611}

Powered by Google App Engine
This is Rietveld 408576698