Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: third_party/WebKit/Source/platform/exported/WrappedResourceResponse.h

Issue 2133693002: Remove class blink::WebURLResponsePrivate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restrict the unowned constructor to WebURLResponse Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/exported/WrappedResourceResponse.h
diff --git a/third_party/WebKit/Source/platform/exported/WrappedResourceResponse.h b/third_party/WebKit/Source/platform/exported/WrappedResourceResponse.h
index 806600a663f6f85b0f4c5f110ac06fe9027e6063..493341f5f12ab897a95158803456be0f64716745 100644
--- a/third_party/WebKit/Source/platform/exported/WrappedResourceResponse.h
+++ b/third_party/WebKit/Source/platform/exported/WrappedResourceResponse.h
@@ -31,33 +31,27 @@
#ifndef WrappedResourceResponse_h
#define WrappedResourceResponse_h
-#include "platform/exported/WebURLResponsePrivate.h"
#include "public/platform/WebURLResponse.h"
-#include "wtf/Allocator.h"
+#include "wtf/Noncopyable.h"
namespace blink {
// WrappedResourceResponse doesn't take ownership of given ResourceResponse,
-// but just holds a pointer to it. It is not copyable (as WebURLResponsePrivate
-// is non-copyable).
+// but just holds a pointer to it. It is not copyable.
class WrappedResourceResponse : public WebURLResponse {
+ WTF_MAKE_NONCOPYABLE(WrappedResourceResponse);
public:
~WrappedResourceResponse() {}
explicit WrappedResourceResponse(ResourceResponse& resourceResponse)
- : WebURLResponse(&m_handle)
+ : WebURLResponse(&resourceResponse)
{
- m_handle.m_resourceResponse = &resourceResponse;
}
explicit WrappedResourceResponse(const ResourceResponse& resourceResponse)
: WrappedResourceResponse(const_cast<ResourceResponse&>(resourceResponse))
{
}
-
-private:
- // This is pointed by m_private.
- WebURLResponsePrivate m_handle;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698