Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2133673003: Run WebGL 1.0 tests as part of the WebGL 2.0 conformance suite. (Closed)

Created:
4 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Corentin Wallez, Geoff Lang, Jamie Madill
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run WebGL 1.0 tests as part of the WebGL 2.0 conformance suite. Now that the shards are more evenly distributed, this is feasible. Increase the number of shards to handle the additional ~15 minutes of run time. BUG=586033 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/7206bff55954e76834cf8bcb8e9fab255abfacbe Cr-Commit-Position: refs/heads/master@{#405246}

Patch Set 1 #

Patch Set 2 : Support --max-version in webgl_conformance test parser. #

Patch Set 3 : Suppress WebGL 1.0 failures when run as part of 2.0 suite. #

Patch Set 4 : Suppress WebGL 1.0 failures when run as part of 2.0 suite. #

Patch Set 5 : More suppressions for failures and flaky tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -59 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 4 chunks +6 lines, -8 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 3 4 6 chunks +62 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance.py View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 2 3 4 3 chunks +20 lines, -4 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 46 chunks +23 lines, -46 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Ken Russell (switch to Gerrit)
Mo: please review. Others: FYI.
4 years, 5 months ago (2016-07-09 02:38:09 UTC) #3
Zhenyao Mo
On 2016/07/09 02:38:09, Ken Russell wrote: > Mo: please review. > > Others: FYI. The ...
4 years, 5 months ago (2016-07-09 04:26:21 UTC) #4
Ken Russell (switch to Gerrit)
On 2016/07/09 04:26:21, Zhenyao Mo wrote: > On 2016/07/09 02:38:09, Ken Russell wrote: > > ...
4 years, 5 months ago (2016-07-12 00:00:13 UTC) #5
Zhenyao Mo
lgtm Please update the expectations accordingly and land only the three bots turn green (on ...
4 years, 5 months ago (2016-07-12 01:04:53 UTC) #6
Zhenyao Mo
On 2016/07/12 01:04:53, Zhenyao Mo wrote: > lgtm > > Please update the expectations accordingly ...
4 years, 5 months ago (2016-07-12 14:08:08 UTC) #7
Ken Russell (switch to Gerrit)
On 2016/07/12 14:08:08, Zhenyao Mo wrote: > On 2016/07/12 01:04:53, Zhenyao Mo wrote: > > ...
4 years, 5 months ago (2016-07-12 18:52:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133673003/80001
4 years, 5 months ago (2016-07-12 22:56:56 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-13 02:16:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133673003/80001
4 years, 5 months ago (2016-07-13 18:05:43 UTC) #15
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names without "master." prefix is ...
4 years, 5 months ago (2016-07-13 19:33:31 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-07-13 19:58:39 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 19:59:46 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:00:18 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7206bff55954e76834cf8bcb8e9fab255abfacbe
Cr-Commit-Position: refs/heads/master@{#405246}

Powered by Google App Engine
This is Rietveld 408576698