content/test/gpu/gpu_tests/webgl_conformance.py - Issue 2133673003: Run WebGL 1.0 tests as part of the WebGL 2.0 conformance suite.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/gpu/gpu_tests/webgl_conformance.py

Issue 2133673003: Run WebGL 1.0 tests as part of the WebGL 2.0 conformance suite. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More suppressions for failures and flaky tests. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/test/gpu/gpu_tests/webgl2_conformance_expectations.py ('k') | content/test/gpu/gpu_tests/webgl_conformance_expectations.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/gpu/gpu_tests/webgl_conformance.py

diff --git a/content/test/gpu/gpu_tests/webgl_conformance.py b/content/test/gpu/gpu_tests/webgl_conformance.py

index dffc795e6fd28e7867caa0910ae37dd32de28494..73af5dfdbe0ad094105f58802b0d1cd28e073d1d 100644

--- a/content/test/gpu/gpu_tests/webgl_conformance.py

+++ b/content/test/gpu/gpu_tests/webgl_conformance.py

@@ -329,11 +329,15 @@ class WebglConformance(gpu_test_base.TestBase):

i = 0

min_version = None

+ max_version = None

while i < len(line_tokens):

token = line_tokens[i]

if token == '--min-version':

i += 1

min_version = line_tokens[i]

+ elif token == '--max-version':

+ i += 1

+ max_version = line_tokens[i]

i += 1

min_version_to_compare = min_version or folder_min_version

@@ -342,6 +346,9 @@ class WebglConformance(gpu_test_base.TestBase):

_CompareVersion(version, min_version_to_compare) < 0):

continue

+ if max_version and _CompareVersion(version, max_version) > 0:

+ continue

if (webgl2_only and not '.txt' in test_name and

(not min_version_to_compare or

not min_version_to_compare.startswith('2'))):