Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl

Issue 2133673002: Push API: Implement and ship PushSubscription.options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl
diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl b/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl
index e4ee9b8108955c09827a3cbe1202e27a89e5a925..86fd2e3a0eafe8e1feaada3c15c157cd11c3ff53 100644
--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl
+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl
@@ -4,7 +4,11 @@
// https://w3c.github.io/push-api/#idl-def-PushSubscriptionOptions
-dictionary PushSubscriptionOptions {
- boolean userVisibleOnly = false;
- BufferSource applicationServerKey;
+[
+ Exposed=(Window,ServiceWorker),
+ RuntimeEnabled=PushMessaging,
+] interface PushSubscriptionOptions {
+ readonly attribute boolean userVisibleOnly;
+ // Mutable by web developer. See https://github.com/w3c/push-api/issues/198.
Peter Beverloo 2016/07/08 18:30:12 Please move this to the source code, IDL is not th
johnme 2016/07/13 17:51:57 Done.
+ [SameObject] readonly attribute ArrayBuffer? applicationServerKey;
};

Powered by Google App Engine
This is Rietveld 408576698