third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl - Issue 2133673002: Push API: Implement and ship PushSubscription.options

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl

Issue 2133673002: Push API: Implement and ship PushSubscription.options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp ('K') | « third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp ('k') | third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptionsInit.idl » ('j') | third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptionsInit.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/push-api/#idl-def-PushSubscriptionOptions	5 // https://w3c.github.io/push-api/#idl-def-PushSubscriptionOptions

6	6

7 dictionary PushSubscriptionOptions {	7 [

8 boolean userVisibleOnly = false;	8 Exposed=(Window,ServiceWorker),

9 BufferSource applicationServerKey;	9 RuntimeEnabled=PushMessaging,

	10 ] interface PushSubscriptionOptions {

	11 readonly attribute boolean userVisibleOnly;

	12 // Mutable by web developer. See https://github.com/w3c/push-api/issues/198.
	Peter Beverloo 2016/07/08 18:30:12 Please move this to the source code, IDL is not th Please move this to the source code, IDL is not the right place for these docs. (Ideally it would be copy/paste from the spec.) johnme 2016/07/13 17:51:57 Done. Show quoted text On 2016/07/08 18:30:12, Peter Beverloo wrote: > Please move this to the source code, IDL is not the right place for these docs. > (Ideally it would be copy/paste from the spec.) Done.
	13 [SameObject] readonly attribute ArrayBuffer? applicationServerKey;

10 };	14 };

OLD	NEW